GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix dataclassses spelling by jly36963 · Pull Request #28837 · python/cpython

Conversation

@jly36963

@jly36963 jly36963 commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jly36963
Fix dataclassses spelling
ef260ed
@jly36963
jly36963 requested a review from ericvsmith as a code owner October 9, 2021 17:59
@bedevere-bot bedevere-bot added the awaiting review label Oct 9, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Oct 9, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 9, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jly36963

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
jly36963 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added skip issue skip news labels Oct 9, 2021
Mariatta
Mariatta approved these changes Oct 9, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 9, 2021
@ericvsmith

ericvsmith commented Oct 9, 2021

Copy link
Copy Markdown
Member

Given that this is a trivial change, I'm going to not require the CLA. But you should go ahead and sign it, anyway, for future contributions. Thanks!
jly36963 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith ericvsmith added the needs backport to 3.10 label Oct 9, 2021
@ericvsmith
ericvsmith merged commit 5b4a767 into python:main Oct 9, 2021
@miss-islington

miss-islington commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @jly36963 for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
jly36963 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2021
@jly36963 @miss-islington
Fix dataclassses spelling (pythonGH-28837)
ab5b1bc 
(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 9, 2021

Copy link
Copy Markdown

GH-28841 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 9, 2021
ericvsmith pushed a commit that referenced this pull request Oct 9, 2021
@miss-islington @jly36963
Fix dataclassses spelling (GH-28837) (GH-28841)
e086bfe 
(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington <[email protected]>

Co-authored-by: Landon Yarrington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jly36963 @the-knights-who-say-ni @ericvsmith @miss-islington @bedevere-bot @Mariatta
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.