GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45249: Fix caret location when end_offset is set to 0 by pablogsal · Pull Request #28855 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 10, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45249

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
bpo-45249: Fix caret location when end_offset is set to 0
e9b2548
@pablogsal pablogsal added 🤖 automerge labels Oct 10, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Oct 10, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 10, 2021
@pablogsal pablogsal mentioned this pull request Oct 10, 2021
bpo-45249: Ensure the traceback module prints correctly syntax errors with ranges #28575
Merged
@pablogsal

pablogsal commented Oct 10, 2021

Copy link
Copy Markdown
Member Author

CC: @blueyed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal requested review from ammaraskar and isidentical October 12, 2021 14:49
isidentical
isidentical approved these changes Oct 16, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 16, 2021
@miss-islington
miss-islington merged commit fe0d9e2 into python:main Oct 16, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 16, 2021
@miss-islington

miss-islington commented Oct 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 16, 2021

Copy link
Copy Markdown

GH-28994 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2021
@pablogsal @miss-islington
bpo-45249: Fix caret location when end_offset is set to 0 (pythonGH-2…
5694622 
…8855)

(cherry picked from commit fe0d9e2)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
miss-islington added a commit that referenced this pull request Oct 16, 2021
@miss-islington @pablogsal
bpo-45249: Fix caret location when end_offset is set to 0 (GH-28855)
5df35fa 
(cherry picked from commit fe0d9e2)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@akulakov akulakov mentioned this pull request Apr 10, 2022
Update doctect SyntaxErrors for location range #89412
Closed
@pablogsal
pablogsal deleted the bpo-45249 branch September 24, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical isidentical approved these changes
@ammaraskar ammaraskar Awaiting requested review from ammaraskar

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @miss-islington @bedevere-bot @isidentical @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.