GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29644: suppress subprocess output from webbrowser by ncoghlan · Pull Request #289 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

When checking for the default X web browser, xdg-settings
may emit messages on stderr if some components (such as
kreadconfig5) are unavailable. These messages aren't of
interest to Python, so we just ignore them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ncoghlan
bpo-29644: suppress subprocess output from webbrowser
9b50aca
When checking for the default X web browser, xdg-settings
may emit messages on stderr if some components (such as
kreadconfig5) are unavailable. These messages aren't of
interest to Python, so we just ignore them.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 25, 2017
@ncoghlan
ncoghlan requested a review from serhiy-storchaka February 25, 2017 07:50
serhiy-storchaka
serhiy-storchaka approved these changes Feb 25, 2017
View reviewed changes
@ncoghlan
ncoghlan merged commit 140792b into python:master Feb 25, 2017
@ncoghlan

ncoghlan commented Feb 25, 2017

Copy link
Copy Markdown
Contributor Author

My assumption is that the codecov check doesn't hit this line because Travis doesn't have an X environment running.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan ncoghlan mentioned this pull request Feb 25, 2017
Require code coverage not drop in a PR python/core-workflow#38
Closed
@ncoghlan
ncoghlan deleted the bpo-29644-suppress-xdg-settings-output branch March 30, 2018 07:45
akruis added a commit to akruis/cpython that referenced this pull request Jul 16, 2021
@akruis
Stackless issue python#289: automatically regenerate slp_exttype.h
9b442f6
Recreate "slp_exttype.h" on every change of "Objects/typeobject.c".
SonicField added a commit to SonicField/cpython that referenced this pull request May 11, 2026
@SonicField
scripts/push.sh: in-tree canonical version with COMMIT-arg structural…
fd0fff7
… fix

Moves the previously-local /data/users/alexturner/phoenix/push.sh into
the cpython repo as cpython/scripts/push.sh so fresh clones and other
machines inherit the structural fix without per-machine setup.

Per supervisor 2026-05-06 15:34Z + librarian 15:33:57Z (cites
D-1776902911 numstat_bundle.sh in-tree precedent for push-hygiene
scripts) + gatekeeper 10:16Z + pythia python#289 scope-local-only audit.

Behavior:
  scripts/push.sh             — push HEAD (the safe default).
  scripts/push.sh COMMIT      — resolve COMMIT, compare to HEAD;
                                 match → proceed; mismatch → REFUSE
                                 with explicit error citing the
                                 3-incident history (D-1776242717,
                                 feedback_verify_head_before_push,
                                 D-1777993894) + 3 alternatives
                                 (no-arg, git-direct, cherry-pick).

Why the COMMIT-arg restriction: `git push origin COMMIT:branch`
fast-forwards EVERYTHING reachable from COMMIT, not just COMMIT.
The ancestor-sweep footgun fired three times; per supervisor
18:14:38Z code-fix > codify directive (D-1778004893), refuse
COMMIT != HEAD at the script boundary.

Path resolution: cd via SCRIPT_DIR/.. so the script works from any
caller cwd inside or outside the repo.

Verified:
  - bash -n scripts/push.sh → syntax OK
  - scripts/push.sh 0d7d31c (HEAD=e68c6ff175) → REFUSE path
    triggers cleanly with both SHAs + 3 alternative invocations
  - HEAD-match path: REQUESTED == HEAD_SHA proceeds to git push

Local /data/users/alexturner/phoenix/push.sh becomes a thin wrapper
that exec-delegates to scripts/push.sh, preserving existing
muscle-memory invocations on this machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ncoghlan @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.