GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35134: Move classobject.h to Include/cpython/ by vstinner · Pull Request #28968 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 15, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.

Remove redundant "#ifndef Py_LIMITED_API" in context.h.

Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.

https://bugs.python.org/issue35134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-35134: Move classobject.h to Include/cpython/
f953b56 
Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.

Remove redundant "#ifndef Py_LIMITED_API" in context.h.

Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.
@vstinner
vstinner requested review from a team, 1st1, markshannon, rhettinger and tiran as code owners October 15, 2021 07:20
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 15, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Oct 15, 2021
@vstinner
vstinner merged commit 8e5de40 into python:main Oct 15, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 15, 2021
@vstinner
vstinner deleted the classobject branch October 15, 2021 07:46
ShivnarenSrinivasan pushed a commit to ShivnarenSrinivasan/cpython that referenced this pull request Oct 15, 2021
@vstinner @ShivnarenSrinivasan
bpo-35134: Move classobject.h to Include/cpython/ (pythonGH-28968)
c82f6be 
Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.

Remove redundant "#ifndef Py_LIMITED_API" in context.h.

Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.
@tacaswell tacaswell mentioned this pull request Oct 26, 2021
FIX: change c includes to account for upstream changes cython/cython#4428
Merged
tacaswell added a commit to tacaswell/cython that referenced this pull request Oct 28, 2021
@tacaswell
FIX: change c includes to account for upstream changes
c55e5ee 
python/cpython#28968 /
8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing
https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a
sub-folder.  The notes on this change suggested to include "Python.h" instead.
tacaswell added a commit to tacaswell/cython that referenced this pull request Oct 28, 2021
@tacaswell
FIX: change c includes to account for upstream changes
98bdc1e 
python/cpython#28968 /
8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing
https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a
sub-folder.  The notes on this change suggested to include "Python.h" instead.
scoder pushed a commit to cython/cython that referenced this pull request Oct 31, 2021
@tacaswell
Change C includes of "longintrepr.h" to account for upstream changes (G…
60ec08b 
…H-4428)

See python/cpython#28968
which is part of implementing
https://bugs.python.org/issue35134
moved the header "longintrepr.h" into a sub-folder.
The notes on this change suggested to include "Python.h" instead.
scoder pushed a commit to cython/cython that referenced this pull request Oct 31, 2021
@tacaswell @scoder
Change C includes of "longintrepr.h" to account for upstream changes (G…
0f7bd0d 
…H-4428)

See python/cpython#28968
which is part of implementing
https://bugs.python.org/issue35134
moved the header "longintrepr.h" into a sub-folder.
The notes on this change suggested to include "Python.h" instead.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 9, 2021
[BUG] longintrepr.h not found cython/cython#4461
Closed
@gaborbernat gaborbernat mentioned this pull request Feb 8, 2022
Fails to build on Python 3.11 - longintrepr.h: No such file or directory aio-libs/aiohttp#6600
Closed
1 task done
@eero-t eero-t mentioned this pull request Jul 20, 2022
CI errors for unrelated plugins collectd/collectd#4027
Open
@llimllib llimllib mentioned this pull request Oct 25, 2022
Doesn't build on python 3.11 Thriftpy/thriftpy2#192
Closed
@apinkney97 apinkney97 mentioned this pull request Oct 25, 2022
Python 3.11 support (src/_rtmidi.cpp:243:12: fatal error: longintrepr.h: No such file or directory) SpotlightKid/python-rtmidi#115
Closed
@HarrisonPace HarrisonPace mentioned this pull request Oct 26, 2022
Won't build in Python 3.11 MKuranowski/aiocsv#10
Closed
@cthoyt cthoyt mentioned this pull request Oct 28, 2022
Installation issues due to newer cython gyorilab/adeft#71
Closed
@Nebu1eto Nebu1eto mentioned this pull request Nov 5, 2022
Python3.11 emcache/emcache#79
Closed
@KaeLL KaeLL mentioned this pull request Nov 8, 2022
gevent build error (IDFGH-8697) espressif/esp-idf#10139
Closed
3 tasks done
@vstinner vstinner mentioned this pull request Apr 10, 2022
Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details #79315
Closed
@jaimergp jaimergp mentioned this pull request May 4, 2023
Rebuild for python311 conda-forge/ambertools-feedstock#111
Closed
@alexaquila alexaquila mentioned this pull request Jun 17, 2023
Broken intall for python 3.11 drufat/triangle#73
Closed
@lindsayad lindsayad mentioned this pull request Aug 8, 2023
Cannot compile because of hit if using python 3.11 idaholab/moose#25141
Closed
@ghost ghost mentioned this pull request Nov 17, 2023
python3.11 fixes xnd-project/libxnd#48
Merged
@lexson-luo

lexson-luo commented Nov 28, 2023

Copy link
Copy Markdown

"Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it." may i check which C files has this line? and which are those C files located?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 28, 2023

Copy link
Copy Markdown
Member Author

may i check which C files has this line? and which are those C files located?

You can search for # *include.*longintrepr regular expression. For example, on Linux, find -name '*.c' -print0|xargs -0 grep -l -E '# *include.*longintrepr' lists C files which include this header file.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveClement SteveClement mentioned this pull request Jan 10, 2024
Current Issues on Ubuntu 24.04 ail-project/ail-framework#199
Open
@icecraft icecraft mentioned this pull request Jun 25, 2024
why py3.11 pip install fairy-doc[cpu] error magicpdf/Magic-Doc#47
Open
@hermannromanek hermannromanek mentioned this pull request Jul 4, 2024
Installation issue on apple M2 fritzsedlazeck/Sniffles#490
Closed
@Eiim Eiim mentioned this pull request Jul 8, 2024
Can't install via pip HearthSim/decrunch#24
Open
@bstreiff bstreiff mentioned this pull request Jul 1, 2025
Python venv dep manager won't build bare68k and pygame bstreiff/tje-disasm#1
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @lexson-luo @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.