GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45557: Fix underscore_numbers in pprint.pprint(). by ericvsmith · Pull Request #29129 · python/cpython

Conversation

@ericvsmith

@ericvsmith ericvsmith commented Oct 21, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

pprint.pprint() always passes underscore_numbers=False to pformat(), it should use underscore_numbers=underscore_numbers.

https://bugs.python.org/issue45557

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericvsmith
Fix underscore_numbers in pprint.pprint().
fd54955
@bedevere-bot bedevere-bot added the awaiting core review label Oct 21, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 21, 2021
@ericvsmith ericvsmith self-assigned this Oct 21, 2021
@ericvsmith ericvsmith added the needs backport to 3.10 label Oct 21, 2021
@ericvsmith
Added blurb.
5bdb851
@ericvsmith

ericvsmith commented Oct 21, 2021

Copy link
Copy Markdown
Member Author

There's no test for this, because in general the pprint module doesn't test pprint.pprint(). I'll open an issue for that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware approved these changes Oct 21, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 21, 2021
@ericvsmith

ericvsmith commented Oct 21, 2021

Copy link
Copy Markdown
Member Author

I created https://bugs.python.org/issue45559 for testing pprint.pprint().
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jpvincent1980
jpvincent1980 approved these changes Oct 21, 2021
View reviewed changes
@ericvsmith
ericvsmith merged commit 087f089 into python:main Oct 21, 2021
@miss-islington

miss-islington commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 21, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2021
@ericvsmith @miss-islington
bpo-45557: Fix underscore_numbers in pprint.pprint(). (pythonGH-29129)
82cf867 
(cherry picked from commit 087f089)

Co-authored-by: Eric V. Smith <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 21, 2021

Copy link
Copy Markdown

GH-29133 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 21, 2021
@ericvsmith
ericvsmith deleted the issue45557 branch October 21, 2021 20:43
miss-islington added a commit that referenced this pull request Oct 21, 2021
@miss-islington @ericvsmith
bpo-45557: Fix underscore_numbers in pprint.pprint(). (GH-29129)
6b75ad5 
(cherry picked from commit 087f089)

Co-authored-by: Eric V. Smith <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Oct 28, 2021
bpo-45613: Set sqlite3.threadsafety dynamically #29227
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes
+1 more reviewer
@jpvincent1980 jpvincent1980 jpvincent1980 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ericvsmith ericvsmith

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ericvsmith @miss-islington @bedevere-bot @zware @jpvincent1980 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.