GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-45608: Document missing `sqlite3` DB-API attributes and methods by erlend-aasland · Pull Request #29219 · python/cpython

Conversation

erlend-aasland commented Oct 25, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Document DB-API required attributes and methods:

sqlite3.apilevel
sqlite3.paramstyle
sqlite3.threadsafety
sqlite3.Cursor.setinputsizes()
sqlite3.Cursor.setoutputsize()

https://bugs.python.org/issue45608

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-45608: Document missing DB-API attributes

e85897a

erlend-aasland requested a review from berkerpeksag as a code owner

October 25, 2021 21:42

the-knights-who-say-ni added the CLA signed label

Oct 25, 2021

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Oct 25, 2021

erlend-aasland requested a review from malemburg

October 25, 2021 21:42

erlend-aasland added needs backport to 3.9 labels

Oct 25, 2021

Erlend E. Aasland added 3 commits

October 25, 2021 23:47


          Formatting: fix italics


          Fix code example formatting

36fafe2


          More formatting fixes.

3f0d232

erlend-aasland changed the title ~~bpo-45608: Document missing sqlite3 DB-API attributes~~ bpo-45608: Document missing sqlite3 DB-API attributes and methods

Oct 25, 2021


          Also document missing cursor methods

8fdd435

erlend-aasland added the skip news label

Oct 25, 2021

erlend-aasland requested a review from pfmoore

October 25, 2021 22:39

pfmoore approved these changes

Oct 26, 2021

View reviewed changes

pfmoore left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just one minor nitpick.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting review labels

Oct 26, 2021


          Remove superfluous '%'

3448f92

erlend-aasland commented Oct 26, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

PTAL, @pfmoore. Thanks for reviewing!

I also pushed a small wording improvement in b087d3a

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Adjust wording

b087d3a

pfmoore approved these changes

Oct 26, 2021

View reviewed changes

erlend-aasland commented Oct 26, 2021

Copy link

Copy Markdown

Contributor Author

Thanks, Paul! @malemburg, does this look good to you?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland mentioned this pull request

Oct 26, 2021

bpo-45613: Set sqlite3.threadsafety dynamically #29227

Merged

erlend-aasland requested a review from willingc

October 26, 2021 22:25

ambv merged commit 88d8a1a into python:main

Oct 28, 2021

miss-islington commented Oct 28, 2021

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Oct 28, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 28, 2021


          bpo-45608: Document missing sqlite3 DB-API attributes and methods (p…

13db640

…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot commented Oct 28, 2021

Copy link

Copy Markdown

GH-29281 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Oct 28, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 28, 2021


          bpo-45608: Document missing sqlite3 DB-API attributes and methods (p…

9787ff2

…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot removed the needs backport to 3.9 label

Oct 28, 2021

bedevere-bot commented Oct 28, 2021

Copy link

Copy Markdown

GH-29282 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland deleted the sqlite-doc-dbapi branch

October 28, 2021 19:37

erlend-aasland commented Oct 28, 2021

Copy link

Copy Markdown

Contributor Author

Thanks, Łukasz!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv pushed a commit that referenced this pull request

Oct 28, 2021


          bpo-45608: Document missing sqlite3 DB-API attributes and methods (G…

1d88b2b

…H-29219) (GH-29281)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

ambv pushed a commit that referenced this pull request

Oct 28, 2021


          bpo-45608: Document missing sqlite3 DB-API attributes and methods (G…

020aa06

…H-29219) (GH-29282)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland mentioned this pull request

May 16, 2022

[sqlite3] some DB-API attributes are undocumented #89771

Closed

erlend-aasland mentioned this pull request

Jul 27, 2022

Improve the sqlite3 reference #95273

Closed

5 tasks done

Reviewers

pfmoore

pfmoore approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

malemburg

Awaiting requested review from malemburg

willingc

Awaiting requested review from willingc

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pfmoore left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erlend-aasland commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Oct 26, 2021

Uh oh!

miss-islington commented Oct 28, 2021

Uh oh!

bedevere-bot commented Oct 28, 2021

Uh oh!

bedevere-bot commented Oct 28, 2021

Uh oh!

erlend-aasland commented Oct 28, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Oct 25, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Oct 26, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.