GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-45677: Reword first section of `sqlite3` docs by erlend-aasland · Pull Request #29326 · python/cpython

Conversation

erlend-aasland commented Oct 29, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

https://bugs.python.org/issue45677

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs

af15b22

erlend-aasland requested a review from berkerpeksag as a code owner

October 29, 2021 22:00

the-knights-who-say-ni added the CLA signed label

Oct 29, 2021

bedevere-bot added the awaiting review label

Oct 29, 2021

erlend-aasland added needs backport to 3.9 skip news docs Documentation in the Doc dir and removed awaiting review labels

Oct 29, 2021

erlend-aasland commented Oct 29, 2021

Copy link

Copy Markdown

Contributor Author

It would be nice to have a native english speaker verify these changes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested a review from willingc

October 29, 2021 22:02

Erlend E. Aasland added 3 commits

October 30, 2021 00:04


          Adjust wording

c1e758d


          Adjust wording again

204052c


          Typo

02d2a53

jacobtylerwalls reviewed

Oct 31, 2021

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend Egeberg Aasland and others added 2 commits

October 31, 2021 09:40


          Update Doc/library/sqlite3.rst

15008ee

Co-authored-by: Jacob Walls <[email protected]>


          Address review: adjust wording

4d53130

AlexWaygood requested changes

Oct 31, 2021

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid improvement, but here are a few thoughts. (I'm not a sqlite expert by any means, but I am a native English speaker, and have a masters in journalism :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting core review label

Oct 31, 2021

Erlend Egeberg Aasland and others added 8 commits

October 31, 2021 14:36


          Update Doc/library/sqlite3.rst

f5ce4af

Co-authored-by: Alex Waygood <[email protected]>


          Update Lib/sqlite3/__init__.py

e9c3e97

Co-authored-by: Alex Waygood <[email protected]>


          Update Doc/library/sqlite3.rst

86efc85

Co-authored-by: Alex Waygood <[email protected]>


          Update Doc/library/sqlite3.rst

6923fee

Co-authored-by: Alex Waygood <[email protected]>


          Update Lib/sqlite3/__init__.py

c794d16

Co-authored-by: Alex Waygood <[email protected]>


          Update Doc/library/sqlite3.rst

f405915

Co-authored-by: Alex Waygood <[email protected]>


          Apply Alex' suggestion, and apply 80 char limit to PR

d451f9d


          Minor adjustment

9bd8121

erlend-aasland requested a review from Mariatta

October 31, 2021 19:54

erlend-aasland commented Nov 1, 2021

Copy link

Copy Markdown

Contributor Author

FYI, @AlexWaygood and @jacobtylerwalls. See also the topic Using personal or passive tone in the docs on Discourse.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland changed the title ~~bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs~~ bpo-45677: Reword first section of sqlite3 docs

Nov 3, 2021

willingc merged commit 6c5a312 into python:main

Nov 15, 2021

bedevere-bot removed the awaiting core review label

Nov 15, 2021

miss-islington commented Nov 15, 2021

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

AlexWaygood reacted with rocket emoji

All reactions

🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Nov 15, 2021

Copy link

Copy Markdown

@willingc: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 15, 2021


          bpo-45677: Reword first section of sqlite3 docs (pythonGH-29326)

d9bc0dd

* bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs

* Adjust wording

* Adjust wording again

* Typo

* Update Doc/library/sqlite3.rst

Co-authored-by: Jacob Walls <[email protected]>

* Address review: adjust wording

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Apply Alex' suggestion, and apply 80 char limit to PR

* Minor adjustment

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 6c5a312)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot commented Nov 15, 2021

Copy link

Copy Markdown

GH-29566 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed needs backport to 3.10 labels

Nov 15, 2021

bedevere-bot commented Nov 15, 2021

Copy link

Copy Markdown

GH-29567 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 15, 2021


          bpo-45677: Reword first section of sqlite3 docs (pythonGH-29326)

fb0613a

* bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs

* Adjust wording

* Adjust wording again

* Typo

* Update Doc/library/sqlite3.rst

Co-authored-by: Jacob Walls <[email protected]>

* Address review: adjust wording

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Apply Alex' suggestion, and apply 80 char limit to PR

* Minor adjustment

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 6c5a312)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland deleted the sqlite-doc-you/part1 branch

November 15, 2021 22:31

erlend-aasland commented Nov 15, 2021

Copy link

Copy Markdown

Contributor Author

Thanks, Carol!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

willingc pushed a commit that referenced this pull request

Nov 15, 2021


          bpo-45677: Reword first section of sqlite3 docs (GH-29326) (GH-29566)

94dad5e

* bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs

* Adjust wording

* Adjust wording again

* Typo

* Update Doc/library/sqlite3.rst

Co-authored-by: Jacob Walls <[email protected]>

* Address review: adjust wording

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Apply Alex' suggestion, and apply 80 char limit to PR

* Minor adjustment

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 6c5a312)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

willingc pushed a commit that referenced this pull request

Nov 15, 2021


          bpo-45677: Reword first section of sqlite3 docs (GH-29326) (GH-29567)

a40d066

* bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs

* Adjust wording

* Adjust wording again

* Typo

* Update Doc/library/sqlite3.rst

Co-authored-by: Jacob Walls <[email protected]>

* Address review: adjust wording

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Apply Alex' suggestion, and apply 80 char limit to PR

* Minor adjustment

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 6c5a312)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

remykarem pushed a commit to remykarem/cpython that referenced this pull request

Dec 7, 2021


          bpo-45677: Reword first section of sqlite3 docs (python#29326)

258ec73

* bpo-45677: Avoid addressing the reader as 'you' in sqlite3 docs

* Adjust wording

* Adjust wording again

* Typo

* Update Doc/library/sqlite3.rst

Co-authored-by: Jacob Walls <[email protected]>

* Address review: adjust wording

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Update Lib/sqlite3/__init__.py

Co-authored-by: Alex Waygood <[email protected]>

* Update Doc/library/sqlite3.rst

Co-authored-by: Alex Waygood <[email protected]>

* Apply Alex' suggestion, and apply 80 char limit to PR

* Minor adjustment

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>

erlend-aasland mentioned this pull request

May 16, 2022

[doc] improve sqlite3 docs #89840

Closed

erlend-aasland mentioned this pull request

Jul 27, 2022

Improve the sqlite3 reference #95273

Closed

5 tasks done

Reviewers

AlexWaygood

AlexWaygood requested changes

berkerpeksag

Awaiting requested review from berkerpeksag

willingc

Awaiting requested review from willingc

Mariatta

Awaiting requested review from Mariatta

+1 more reviewer

jacobtylerwalls

jacobtylerwalls left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Nov 1, 2021

Uh oh!

miss-islington commented Nov 15, 2021

Uh oh!

bedevere-bot commented Nov 15, 2021

Uh oh!

bedevere-bot commented Nov 15, 2021

Uh oh!

bedevere-bot commented Nov 15, 2021

Uh oh!

erlend-aasland commented Nov 15, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

erlend-aasland commented Oct 29, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.