GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-10572: Add sqlite3 test back in PGO test suite by erlend-aasland · Pull Request #29327 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Oct 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue10572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-10572: Fixup Lib/test/libregrtest/pgo.py
47ba143
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 29, 2021
@bedevere-bot bedevere-bot added the awaiting review label Oct 29, 2021
@erlend-aasland
erlend-aasland requested a review from brettcannon October 29, 2021 22:14
@erlend-aasland erlend-aasland added the skip news label Oct 29, 2021
@erlend-aasland

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

cc. @brettcannon
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title bpo-10572: Fixup Lib/test/libregrtest/pgo.py bpo-10572: Add sqlite3 test back in PGO test suite Oct 29, 2021
@erlend-aasland

erlend-aasland commented Oct 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

PGO on main misses the sqlite3 tests, so some buildbots now fail at test_regrtest. This PR adds the sqlite3 tests back to test_regrtest.

0:00:50 load avg: 6.14 [37/44] test_sqlite
0:00:50 load avg: 6.14 [38/44] test_statistics -- test_sqlite failed (uncaught exception)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Oct 29, 2021
bpo-10572: Move sqlite3 tests to Lib/test #29304
Merged
@erlend-aasland
erlend-aasland requested a review from ambv October 30, 2021 06:23
@erlend-aasland erlend-aasland mentioned this pull request Nov 1, 2021
bpo-45138: Expand traced SQL statements in sqlite3 trace callback #28240
Merged
@erlend-aasland
erlend-aasland requested a review from pablogsal November 1, 2021 08:47
pablogsal
pablogsal approved these changes Nov 1, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 1, 2021
@pablogsal
pablogsal merged commit 762a4dc into python:main Nov 1, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 1, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-fix branch November 1, 2021 09:57
@voidspace voidspace mentioned this pull request Jun 20, 2022
Move test sub-packages to Lib/test #54781
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.