GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-10572: Move `sqlite3` tests to `Lib/test` by erlend-aasland · Pull Request #29304 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Oct 29, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue10572

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland added 5 commits October 29, 2021 09:52
Erlend E. Aasland
Reorganise files
0a32778
deleted Lib/sqlite3/test/__init__.py
renamed /test/test_sqlite.py -> Lib/test/test_sqlite3/__init__.py
renamed /sqlite3/test/test_backup.py -> Lib/test/test_sqlite3/test_backup.py
renamed /sqlite3/test/test_dbapi.py -> Lib/test/test_sqlite3/test_dbapi.py
renamed /sqlite3/test/test_dump.py -> Lib/test/test_sqlite3/test_dump.py
renamed /sqlite3/test/test_factory.py -> Lib/test/test_sqlite3/test_factory.py
renamed /sqlite3/test/test_hooks.py -> Lib/test/test_sqlite3/test_hooks.py
renamed /sqlite3/test/test_regression.py -> Lib/test/test_sqlite3/test_regression.py
renamed /sqlite3/test/test_transactions.py -> Lib/test/test_sqlite3/test_transactions.py
renamed /sqlite3/test/test_types.py -> Lib/test/test_sqlite3/test_types.py
renamed /sqlite3/test/test_userfunctions.py -> Lib/test/test_sqlite3/test_userfunctions.py
Erlend E. Aasland
Fixup Lib/test/test_sqlite3/__init__.py
1333aa9
Erlend E. Aasland
Add NEWS
f5f1bde
Erlend E. Aasland
Update Makefile
195709a
Erlend E. Aasland
Fix inter-test includes
571a515
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner October 29, 2021 08:12
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 29, 2021
@bedevere-bot bedevere-bot added the awaiting review label Oct 29, 2021
@erlend-aasland

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

After Serhiy's eminent cleanup in commit 3e19409, the main argument against moving the tests is now moot. Thanks to Serhiy's cleanup, moving the tests is now a much smaller PR than the previous attempt (GH-24148).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland requested a review from brettcannon October 29, 2021 08:15
Erlend E. Aasland added 2 commits October 29, 2021 10:43
Erlend E. Aasland
Fixup PCbuild
351dcae
Erlend E. Aasland
Revert 571a515
f8889d2
@erlend-aasland
erlend-aasland requested a review from a team as a code owner October 29, 2021 08:45
Erlend E. Aasland added 3 commits October 29, 2021 10:49
Erlend E. Aasland
Allow ./python -m test.test_sqlite3
b6f50d9
Erlend E. Aasland
Fixup __init__.py debug message
cbb18a9
Erlend E. Aasland
Simplify __init__
7f2ee3b
brettcannon
brettcannon requested changes Oct 29, 2021
View reviewed changes
Comment thread Lib/test/test_sqlite3/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_sqlite3/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting review label Oct 29, 2021
@bedevere-bot

bedevere-bot commented Oct 29, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting changes label Oct 29, 2021
Erlend Egeberg Aasland and others added 5 commits October 29, 2021 22:20
Erlend Egeberg Aasland @brettcannon
Update Lib/test/test_sqlite3/__main__.py
bca9a72
Co-authored-by: Brett Cannon <[email protected]>
Erlend E. Aasland
Address review: remove useless import
35f6334
Erlend E. Aasland
Revert "Address review: remove useless import"
52b9164
This reverts commit 35f6334 and adds a comment on why it was needed
Erlend E. Aasland
Address review: remove uneeded 'if __name__ == "__main__"'
5d5e84f
Erlend E. Aasland
Add comment and clean up __init__
75fe05b
@erlend-aasland

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

I believe I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Oct 29, 2021
@bedevere-bot

bedevere-bot commented Oct 29, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot
bedevere-bot requested a review from brettcannon October 29, 2021 21:09
brettcannon
brettcannon reviewed Oct 29, 2021
View reviewed changes
Comment thread Lib/test/test_sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_sqlite3/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

brettcannon added 3 commits October 29, 2021 14:44
@brettcannon
Add a period
76b8533
@brettcannon
Add a period
200d2fc
@brettcannon
Add a period
f0b13eb
@brettcannon
brettcannon self-requested a review October 29, 2021 21:45
brettcannon
brettcannon approved these changes Oct 29, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Oct 29, 2021
@brettcannon

brettcannon commented Oct 29, 2021

Copy link
Copy Markdown
Member

It all LGTM, I just want to double-check the tests still run, so I'm waiting on CI to finish at least one of the test runs. 😄

erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brettcannon brettcannon added the 🤖 automerge label Oct 29, 2021
@miss-islington

miss-islington commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit 62bf263 into python:main Oct 29, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 29, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-move-tests branch October 29, 2021 22:08
@erlend-aasland

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Brett!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Oct 29, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 Pro 3.x has failed when building commit 62bf263.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/596/builds/1321) and take a look at the build logs.
  4. Check if the failure is related to this commit (62bf263) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/596/builds/1321

Failed tests:

  • test_os
  • test_regrtest

Failed subtests:

  • test_walk_bad_dir - test.test_os.BytesWalkTests

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

395 tests OK.

10 slowest tests:

  • test_multiprocessing_spawn: 2 min 43 sec
  • test_peg_generator: 2 min 27 sec
  • test_unparse: 1 min 59 sec
  • test_concurrent_futures: 1 min 48 sec
  • test_tokenize: 1 min 39 sec
  • test_asyncio: 1 min 19 sec
  • test_lib2to3: 1 min 14 sec
  • test_unicodedata: 1 min 6 sec
  • test_distutils: 1 min 6 sec
  • test_capi: 1 min 5 sec

34 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_tix test_tk test_ttk_guionly
test_wait3 test_wait4 test_xxlimited test_xxtestfuzz
test_zipfile64

2 re-run tests:
test_os test_regrtest

1 test run no tests:
test_regrtest

Total duration: 15 min 30 sec

Click to see traceback logs
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 396, in temp_dir
    yield path
    ^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 449, in temp_cwd
    yield cwd_dir
    ^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 658, in main
    self._main(tests, kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 731, in _main
    sys.exit(0)
    ^^^^^^^^^^^
SystemExit: 0


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 197, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_8352�\\test_python_worker_7008�'


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\__main__.py", line 2, in <module>
    main()
    ^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 736, in main
    Regrtest().main(tests=tests, **kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 652, in main
    with os_helper.temp_cwd(test_cwd, quiet=True):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 447, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 401, in temp_dir
    rmtree(path)
    ^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 358, in rmtree


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_os.py", line 1428, in test_walk_bad_dir
    os.rename(path1, path1new)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
PermissionError: [WinError 5] Access is denied: '@test_12176_tmp�\\TEST1\\SUB1' -> '@test_12176_tmp�\\TEST1\\SUB1.new'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

See GH-29327 for the buildbot fix.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@voidspace voidspace mentioned this pull request Jun 20, 2022
Move test sub-packages to Lib/test #54781
Closed
@erlend-aasland

erlend-aasland commented Jul 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

We should consider mentioning this change in the 3.11 What's New document. Re #94998.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 20, 2022
@erlend-aasland
[3.11] pythongh-29304: Mention sqlite3 test relocation in What's New
c8c7f3e
@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

Proposed What's New entry in gh-95059.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zware zware mentioned this pull request Jul 20, 2022
[3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation #95061
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @brettcannon @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.