GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45578: add tests for `dis.distb` by sobolevn · Pull Request #29332 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 30, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the first PR for this issue (I plan to make the second one with dis.findlabels tests).

https://bugs.python.org/issue45578

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
bpo-45578: add tests for dis.distb
79b77da
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 30, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 30, 2021
@bedevere-bot bedevere-bot added the awaiting review label Oct 30, 2021
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@bedevere-bot

bedevere-bot commented Nov 2, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 79b77da 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@ambv

ambv commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

Adding buildbot tests as meddling with global state usually causes refleaks or environment change failures.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Nov 3, 2021

Copy link
Copy Markdown
Member Author

Is it related?

----------------------------------------------------------------------
Ran 1 test in 0.001s
OK
......
1 test failed again:
    test_sqlite3
== Tests result: FAILURE then FAILURE ==
415 tests OK.
10 slowest tests:
- test_signal: 31 min 9 sec
- test_pydoc: 29 min 44 sec
- test_asyncio: 18 min 44 sec
- test_concurrent_futures: 18 min 24 sec
- test_multiprocessing_spawn: 15 min 42 sec
- test_peg_generator: 15 min 23 sec
- test_multiprocessing_forkserver: 9 min 37 sec
- test_multiprocessing_fork: 8 min 25 sec
- test_gdb: 8 min 23 sec
- test_pickle: 5 min 10 sec
1 test failed:
    test_sqlite3
14 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_smtpnet
    test_ssl test_startfile test_tix test_tk test_ttk_guionly
    test_winconsoleio test_winreg test_winsound test_zipfile64
2 re-run tests:
    test_sqlite3 test_unittest
Total duration: 45 min 44 sec
Tests result: FAILURE then FAILURE
make: *** [Makefile:1357: buildbottest] Error 2
program finished with exit code 2
elapsedTime=2746.496299
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

This is indeed unrelated, Nikita. It's fixed by GH-29382 already.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv added needs backport to 3.9 labels Nov 3, 2021
@ambv
ambv merged commit e346f19 into python:main Nov 3, 2021
@miss-islington

miss-islington commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting review label Nov 3, 2021
@miss-islington

miss-islington commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e346f196819aeb02a8a94205ce3e1536c4c2f105 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned ambv Nov 3, 2021
@miss-islington

miss-islington commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Sorry @sobolevn and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e346f196819aeb02a8a94205ce3e1536c4c2f105 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 3, 2021

Copy link
Copy Markdown

GH-29385 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 3, 2021
ambv pushed a commit to ambv/cpython that referenced this pull request Nov 3, 2021
@sobolevn @ambv
[3.10] bpo-45578: add tests for dis.distb (pythonGH-29332).
ea15800
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Nov 3, 2021
@sobolevn @ambv
[3.9] bpo-45578: add tests for dis.distb (pythonGH-29332).
4607f51
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 3, 2021

Copy link
Copy Markdown

GH-29386 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 3, 2021
ambv added a commit that referenced this pull request Nov 3, 2021
@ambv @sobolevn
[3.10] bpo-45578: add tests for dis.distb (GH-29332) (GH-29385)
fd6b70d
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <[email protected]>
ambv added a commit that referenced this pull request Nov 3, 2021
@ambv @sobolevn
[3.9] bpo-45578: add tests for dis.distb (GH-29332) (#29386)
8198617
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn sobolevn mentioned this pull request Dec 11, 2021
bpo-45578: add a test case for dis.findlabels #30058
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @bedevere-bot @ambv @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.