GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value… by iritkatriel · Pull Request #29404 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

… to NULL

This PR tidies up exception handling in Future/Task._make_cancelled_error to make it clearer what's happening and pave the way for a refactor of how the interpreter represents exceptions.

https://bugs.python.org/issue45711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value…
fe40d99 
… to NULL
@iritkatriel
iritkatriel requested review from 1st1, cjerdonek, gvanrossum and markshannon November 4, 2021 13:24
@iritkatriel
iritkatriel requested a review from asvetlov as a code owner November 4, 2021 13:24
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 4, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 4, 2021
@iritkatriel iritkatriel added the skip news label Nov 4, 2021
iritkatriel
iritkatriel commented Nov 7, 2021
View reviewed changes
Comment thread Modules/_asynciomodule.c
/* Transfer ownership of exc_value from exc_state to exc since we are
done with it. */
PyException_SetContext(exc, exc_state->exc_value);
exc_state->exc_value = NULL;

@iritkatriel iritkatriel Nov 7, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that PyErr_Occurred checks whether the type is NULL, not the value. So setting just the value to NULL here doesn't follow the interpreter's semantics for the triplet.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gvanrossum
gvanrossum reviewed Nov 7, 2021
View reviewed changes
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
fix whitespace
78c70ac
asvetlov
asvetlov approved these changes Nov 10, 2021
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the PR is correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 10, 2021
gvanrossum
gvanrossum approved these changes Nov 10, 2021
View reviewed changes
@iritkatriel
iritkatriel merged commit 05fbd60 into python:main Nov 10, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 10, 2021
@iritkatriel
iritkatriel deleted the bpo-45711-type_val_tb branch November 10, 2021 19:20
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@iritkatriel remykarem
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value…
d6e9dc6 
… to NULL (pythonGH-29404)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@iritkatriel remykarem
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value…
6158fb0 
… to NULL (pythonGH-29404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@cjerdonek cjerdonek Awaiting requested review from cjerdonek
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @asvetlov @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.