GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45723: Prepare support for autoconf 2.71 (GH-29441) by tiran · Pull Request #29441 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 6, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

AC_PROG_EGREP should be checked explicitly.

AC_CONFIG_HEADER -> AC_CONFIG_HEADERS

AC_USE_SYSTEM_EXTENSIONS must be defined before first use of AC_LINK
or AC_COMPILE macros.

STDC_HEADERS and AC_HEADER_TIME are obsolete.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 6, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 6, 2021
@tiran
tiran force-pushed the bpo-45723-prep271 branch from c4fe80a to fa14a14 Compare November 7, 2021 09:24
@tiran tiran added the skip news label Nov 7, 2021
@tiran
tiran marked this pull request as ready for review November 7, 2021 09:34
@tiran
tiran requested a review from rhettinger as a code owner November 7, 2021 09:34
@tiran
tiran force-pushed the bpo-45723-prep271 branch from fa14a14 to 2b2a10e Compare November 7, 2021 10:18
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 7, 2021
@bedevere-bot

bedevere-bot commented Nov 7, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 2b2a10ebcb4216c271248e2191c64f29a7a68912 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 7, 2021
@tiran
tiran force-pushed the bpo-45723-prep271 branch from 2b2a10e to 2ffa2cb Compare November 8, 2021 07:17
@tiran
tiran requested a review from erlend-aasland November 8, 2021 12:08
@tiran

tiran commented Nov 8, 2021

Copy link
Copy Markdown
Member Author

All changes are based on the output of 2.71's autoupdate tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland reviewed Nov 8, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and left some comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the bpo-45723-prep271 branch from 2ffa2cb to c224b32 Compare November 8, 2021 12:50
@tiran

tiran commented Nov 8, 2021

Copy link
Copy Markdown
Member Author

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete.
configure.ac:660: You should run autoupdate.
erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete.
configure.ac:660: You should run autoupdate.

Oh, well 😆

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran

tiran commented Nov 8, 2021

Copy link
Copy Markdown
Member Author

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Nov 8, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

It seems that we can use AC_PROG_CC and check ac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’
(including the empty string), then CC can compile code as standard
C 1999, and this mode has been enabled
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

BTW, we need to make sure we set CFLAGS before calling AC_PROG_CC, so we don't accidentally default to -g -O2.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran

tiran commented Nov 8, 2021

Copy link
Copy Markdown
Member Author

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

It seems that we can use AC_PROG_CC and check ac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’
(including the empty string), then CC can compile code as standard
C 1999, and this mode has been enabled

autoconf 2.71 no longer defines the variable ac_cv_prog_cc_c99. autoconf 2.69 only defines it for AC_PROG_CC_STDC.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Nov 8, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think one NEWS entry is enough ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tiran
bpo-45723: Prepare support for autoconf 2.71
6a08338
``AC_PROG_EGREP`` should be checked explicitly.

``AC_CONFIG_HEADER`` -> ``AC_CONFIG_HEADERS``

``AC_USE_SYSTEM_EXTENSIONS`` must be defined before first use of ``AC_LINK``
or ``AC_COMPILE`` macros.

``STDC_HEADERS`` and ``AC_HEADER_TIME`` are obsolete.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
tiran force-pushed the bpo-45723-prep271 branch from f8bfcf8 to 6a08338 Compare November 8, 2021 17:59
@tiran

tiran commented Nov 8, 2021

Copy link
Copy Markdown
Member Author

LGTM, but I think one NEWS entry is enough ;)

Oops :)

I have removed the second entry and rebased the PR.

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran changed the title bpo-45723: Prepare support for autoconf 2.71 bpo-45723: Prepare support for autoconf 2.71 (GH-29441) Nov 8, 2021
@tiran
tiran merged commit cbab997 into python:main Nov 8, 2021
@tiran
tiran deleted the bpo-45723-prep271 branch November 8, 2021 18:31
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 8, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45723: Prepare support for autoconf 2.71 (pythonGH-29441)
dc91e43
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@tiran remykarem
bpo-45723: Prepare support for autoconf 2.71 (pythonGH-29441)
2ab74a4
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
@mattip mattip mentioned this pull request Nov 23, 2022
Forward declare timespec struct numpy/numpy#22621
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @bedevere-bot @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.