GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45723: Detect missing pkg-config (GH-29442) by tiran · Pull Request #29442 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 6, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
tiran requested review from ned-deily and pablogsal November 6, 2021 16:04
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 6, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 6, 2021
@tiran tiran changed the title Detect missing pkg-config bpo-45723: Detect missing pkg-config Nov 6, 2021
pablogsal
pablogsal reviewed Nov 6, 2021
View reviewed changes
Comment thread configure Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran force-pushed the bpo-45723-pkgconf branch from af36054 to 2fa083d Compare November 6, 2021 16:58
ned-deily
ned-deily reviewed Nov 6, 2021
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ned-deily

ned-deily commented Nov 6, 2021

Copy link
Copy Markdown
Member 
[...]
config.status: creating pyconfig.h
creating Modules/Setup.local
creating Makefile

pkg-config is missing. Some dependencies may not be detected correctly.


If you want a release build with all stable optimizations active (PGO, etc),
please run ./configure --enable-optimizations


$ pkg-config
Must specify package names on the command line
$ which pkg-config
/usr/bin/pkg-config

This is on a reasonably vanilla Debian system. Also the same on macOS with pkg-config installed from MacPorts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Strange ... could you please paste the output of grep PKG_CONFIG config.log ?

My system (Fedora 34):

$ grep PKG_CONFIG config.log 
ac_cv_env_PKG_CONFIG_LIBDIR_set=
ac_cv_env_PKG_CONFIG_LIBDIR_value=
ac_cv_env_PKG_CONFIG_PATH_set=
ac_cv_env_PKG_CONFIG_PATH_value=
ac_cv_env_PKG_CONFIG_set=
ac_cv_env_PKG_CONFIG_value=
ac_cv_path_ac_pt_PKG_CONFIG=/usr/bin/pkg-config
ac_cv_prog_ac_ct_PKG_CONFIG=/usr/bin/pkg-config
PKG_CONFIG='/usr/bin/pkg-config'
PKG_CONFIG_LIBDIR=''
PKG_CONFIG_PATH=''
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 6, 2021

Copy link
Copy Markdown
Member Author

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

AC_PATH_TOOL is provided by autoconf/programs.m4.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 6, 2021

Copy link
Copy Markdown
Member Author

D'oh, I put test -n to test the output message and forgot to replace it with test -z.
ned-deily reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran marked this pull request as ready for review November 6, 2021 19:01
ned-deily
ned-deily approved these changes Nov 6, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 6, 2021
tiran added 4 commits November 7, 2021 10:36
@tiran
bpo-45723: Detect missing pkg-config
265284d 
Signed-off-by: Christian Heimes <[email protected]>
@tiran
Get rid of extra new lines
f4fa05f
@tiran
Use correct check
4342b78
@tiran
blurb
3061c4b
@tiran
tiran force-pushed the bpo-45723-pkgconf branch from 8c59d49 to 3061c4b Compare November 7, 2021 09:36
@tiran tiran changed the title bpo-45723: Detect missing pkg-config bpo-45723: Detect missing pkg-config (GH-29442) Nov 7, 2021
@tiran
tiran merged commit be3cd5c into python:main Nov 7, 2021
@tiran
tiran deleted the bpo-45723-pkgconf branch November 7, 2021 10:18
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45723: Detect missing pkg-config (pythonGH-29442)
3c415d9
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@tiran remykarem
bpo-45723: Detect missing pkg-config (pythonGH-29442)
1b288cb
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal left review comments
@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @ned-deily @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.