GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) by erlend-aasland · Pull Request #29466 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 8, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Add PY_CHECK_CC_WARNING helper
  • Normalise variable name: ac_cv_[enable|disable]_[flag_name]_warning; for example ac_cv_disable_unused_result_warning
  • Use AS_IF to check results and add flags

No new cache vars added, so there is no speedups; only simplified ac code.

Bonus: fixed a misspelling bug (see ac_cv_enable_enable_strict_prototypes_warning)

https://bugs.python.org/issue45723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
Add macro for disabling/enabling CC warnings
bfacf4c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 8, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 8, 2021
@erlend-aasland

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

cc. @tiran
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the skip news label Nov 8, 2021
tiran
tiran reviewed Nov 8, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 6 commits November 8, 2021 10:30
Erlend Egeberg Aasland @tiran
Use AS_VAR_IF iso. AS_IF
88185ab 
Co-authored-by: Christian Heimes <[email protected]>
Erlend E. Aasland
Use AS_VAR_IF iso. AS_IF
6901522
Erlend E. Aasland
Use AS_VAR_IF for strict aliasing flag
87986e6
Erlend E. Aasland
Use AS_CASE for disable unused result warning
73ff497
Erlend E. Aasland
Make it possible to supply custom msg
7e5a175
Erlend E. Aasland
Remove newline
1db815e
@erlend-aasland
erlend-aasland marked this pull request as ready for review November 8, 2021 10:47
@erlend-aasland
erlend-aasland requested a review from tiran November 8, 2021 10:47
tiran
tiran reviewed Nov 8, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Address review
304f780 
- Use AS_VAR_IF() a couple of more times
- Use CFLAGS iso. CC when overriding compiler flags
@erlend-aasland
erlend-aasland requested a review from tiran November 8, 2021 12:03
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@bedevere-bot

bedevere-bot commented Nov 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 304f780 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@erlend-aasland

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

Do you want a NEWS item for this, @tiran?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran approved these changes Nov 8, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 8, 2021
@erlend-aasland

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-45723: Add macro for disabling/enabling CC warnings bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) Nov 8, 2021
@tiran
tiran merged commit 9bd0cf5 into python:main Nov 8, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 8, 2021
@erlend-aasland
erlend-aasland deleted the ac-cc-flags branch November 8, 2021 17:59
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland @tiran remykarem
bpo-45723: Add macro for disabling/enabling CC warnings (pythonGH-29466)
778b147 
Co-authored-by: Christian Heimes <[email protected]>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Erlend Egeberg Aasland @tiran remykarem
bpo-45723: Add macro for disabling/enabling CC warnings (pythonGH-29466)
29514b3 
Co-authored-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.