GeezerVison

@JelleZijlstra, reckon this can be merged soon? :)

Looking at this again I'm not so sure, sorry. This adds more text than was there before, but the new text is a little repetitive. I do like the additional links though.

I feel like a broader problem with the language reference is that it veers too much into describing how concrete built-in types handle an operation, and not enough into how exactly the operation works. Here, for example, there is no precise description of when __class_getitem__ is called instead of __getitem__. That description exists only in the docs for __class_getitem__, but logically it should be part of the description of the subscript operator. The fact that the key is a tuple unless there is exactly one element shows up in a parenthetical in the text around mappings. (It's also wrong: obj[1,] is a tuple key, not an integer. The next section on slicing gets this right.) Also, type[int] works through deep magic in the interpreter, since type has neither a __getitem__ nor a __class_getitem__ magic, but nothing in the reference mentions this.

See also bpo-46754.

Looking at this again I'm not so sure, sorry.

Thanks for taking a look! I'll have a think tomorrow about whether I want to try revising this PR, or just close it.

Here, for example, there is no precise description of when __class_getitem__ is called instead of __getitem__. That description exists only in the docs for __class_getitem__, but logically it should be part of the description of the subscript operator.

Perhaps you're right that that information might be better found in this document, but tbqh I don't have the energy to move that section from the data model to here after spending so long adding that section to the data model in GH-29389 :(

@JelleZijlstra I've had another bash at it. I've tried to make the section less repetitive and increase the accuracy of the section regarding the "expression list".

The core aims of this PR are to:

1. Make more prominent mention of the fact that subscriptions can also result in __class_getitem__ being called, as well as __getitem__.
2. Add more links to to docs elsewhere on __class_getitem__.

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

GH-31743 is a backport of this pull request to the 3.10 branch.

GH-31744 is a backport of this pull request to the 3.9 branch.

Thanks so much for helping get this over the line @JelleZijlstra!