GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89928: consume dev_t with PyLong_FromUnsignedLongLong by AMDmi3 · Pull Request #29494 · python/cpython

Conversation

@AMDmi3

@AMDmi3 AMDmi3 commented Nov 9, 2021 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45767

  • Issue: Fix types for dev_t processing in posix module: use uint64_t (unsigned) instead of int64_t (signed) #89928

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 9, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 9, 2021
@github-actions

github-actions Bot commented Dec 10, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 10, 2021
@kumaraditya303

kumaraditya303 commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

Can you add a news entry ? https://blurb-it.herokuapp.com/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AMDmi3
bpo-45767: consume dev_t with PyLong_FromUnsignedLongLong (pythonGH-2…
54411d4 
…9494)
@AMDmi3
AMDmi3 force-pushed the patch-1 branch from 85afa5e to 54411d4 Compare January 20, 2022 11:38
@AMDmi3

AMDmi3 commented Jan 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Can you add a news entry ? https://blurb-it.herokuapp.com/

Sure, done. Also added GH pull request number to summary and rebased.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaxwellDupre

MaxwellDupre commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

I dont see the following:
#if defined(__FreeBSD__) #define DEVICE_MAJORMINOR_T int #else #define DEVICE_MAJORMINOR_T unsigned int #endif
In your Files changed, please explain?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AMDmi3

AMDmi3 commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

I dont see the following:

Because it's not there, obviously. This PR only addresses one aspect of the problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MaxwellDupre
MaxwellDupre approved these changes Apr 18, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 18, 2022
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@erlend-aasland erlend-aasland changed the title bpo-45767: consume dev_t with PyLong_FromUnsignedLongLong gh-89928: consume dev_t with PyLong_FromUnsignedLongLong Jan 5, 2024
@AMDmi3 AMDmi3 mannequin mentioned this pull request Mar 28, 2024
Fix types for dev_t processing in posix module: use uint64_t (unsigned) instead of int64_t (signed) #89928
Closed
@serhiy-storchaka

serhiy-storchaka commented Jun 4, 2024

Copy link
Copy Markdown
Member

Thank you for your contribution, but more complex #31794 was merged instead.
AMDmi3 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@AMDmi3 @kumaraditya303 @MaxwellDupre @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.