GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45711: remove unnecessary DUP_TOP and POP in exception handling by iritkatriel · Pull Request #29495 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 9, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-45711: remove unnecessary DUP_TOP and POP in exception handling
ebd9c9f
@iritkatriel
iritkatriel requested a review from markshannon November 9, 2021 17:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 9, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 9, 2021
@iritkatriel

iritkatriel commented Nov 9, 2021

Copy link
Copy Markdown
Member Author

@markshannon is there a reason not to do this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
update expected output in test_dis
31b7b8e
@iritkatriel iritkatriel added the skip news label Nov 9, 2021
@markshannon markshannon self-assigned this Nov 10, 2021
@markshannon

markshannon commented Nov 10, 2021

Copy link
Copy Markdown
Member

Looks good.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 4cdeee5 into python:main Nov 10, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 10, 2021
@iritkatriel
iritkatriel deleted the bpo-45711-simplify-JUMP_IF_NOT_EXC_MATCH branch November 10, 2021 18:33
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@iritkatriel remykarem
bpo-45711: remove unnecessary DUP_TOP and POP in exception handling (p…
82262ed 
…ythonGH-29495)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@iritkatriel remykarem
bpo-45711: remove unnecessary DUP_TOP and POP in exception handling (p…
df51377 
…ythonGH-29495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@markshannon markshannon

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.