GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45723: Remove dead code for obsolete `--with-dyld` option by erlend-aasland · Pull Request #29500 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 9, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

https://bugs.python.org/issue45723

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-45723: Remove dead code for obsolete --with-dyld option
b62f459 
Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 9, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 9, 2021
@erlend-aasland erlend-aasland added the skip news label Nov 9, 2021
@erlend-aasland
erlend-aasland requested a review from tiran November 9, 2021 19:34
tiran
tiran approved these changes Nov 9, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 9, 2021
tiran
tiran suggested changes Nov 9, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to regenerate configure, too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting merge labels Nov 9, 2021
@bedevere-bot

bedevere-bot commented Nov 9, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
regenerate configure
bb6fe7d
@erlend-aasland
erlend-aasland requested a review from tiran November 9, 2021 20:42
tiran
tiran approved these changes Nov 9, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Nov 9, 2021
@tiran tiran added the 🤖 automerge label Nov 9, 2021
@erlend-aasland

erlend-aasland commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

You need to regenerate configure, too.

Hm, we could add a configure/configure.ac check to the Check if generated files are up to date CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 9, 2021

Copy link
Copy Markdown
Member

You need to regenerate configure, too.

Hm, we could add a configure/configure.ac check to the Check if generated files are up to date CI.

First I like to move my repo to python org and figure out hosting on ghcr.io.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 49171aa into python:main Nov 9, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 9, 2021
@erlend-aasland
erlend-aasland deleted the ac-remove-dead-code branch November 9, 2021 21:06
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
be6e319 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
30388b9 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
e937253 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
86e565a 
…GH-29500)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland remykarem
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
f892757 
…GH-29500)

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

Automerge-Triggered-By: GH:tiran
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Erlend Egeberg Aasland remykarem
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
ba54db9 
…GH-29500)

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

Automerge-Triggered-By: GH:tiran
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @tiran @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.