GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45711: assert that the type of exc_info is redundant by iritkatriel · Pull Request #29518 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 10, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I suggest we commit this so that the diff when we remove the type shows why we think it's safe to do so.

https://bugs.python.org/issue45711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-45711: assert that the type of exc_info is redundant
d7c8d15
@iritkatriel
iritkatriel requested a review from markshannon November 10, 2021 19:17
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 10, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 10, 2021
@iritkatriel iritkatriel added the skip news label Nov 10, 2021
@bedevere-bot

bedevere-bot commented Nov 10, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d7c8d15 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 10, 2021
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 10, 2021
@iritkatriel
iritkatriel requested a review from gvanrossum November 11, 2021 10:29
@iritkatriel

iritkatriel commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

The test_gdb failure is happening on other branches as well, so this is looking good. Let me know if you think there is value in committing this (I thinking if something breaks in the future, after we remove the type, it might help to have this commit in the history).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Nov 11, 2021

Copy link
Copy Markdown
Member

I worry that the code won't be completely removed even by PGO/LTO. Or am I too fearful?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

Right, I can make it a macro working in debug mode only.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
convert to macro, Py_DEBUG only
f5cb124
@iritkatriel iritkatriel mentioned this pull request Nov 12, 2021
(exc, val, tb) triplet to one value faster-cpython/ideas#106
Closed
@markshannon

markshannon commented Nov 12, 2021

Copy link
Copy Markdown
Member

Looks good 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Nov 12, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 12, 2021
@iritkatriel
iritkatriel merged commit de3db14 into python:main Nov 12, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 12, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@iritkatriel remykarem
bpo-45711: assert that the type of exc_info is redundant (pythonGH-29518
ce9802a 
)
@iritkatriel
iritkatriel deleted the bpo-45711-exc_info_type_redundant branch January 13, 2022 15:35
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@iritkatriel remykarem
bpo-45711: assert that the type of exc_info is redundant (pythonGH-29518
8fd8781 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @bedevere-bot @gvanrossum @markshannon @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.