GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45711: Re-bump the magic number and update doc by brandtbucher · Pull Request #29528 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 11, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@iritkatriel, it looks like I chose the same new magic number as you for my recent PR. Sorry about that!

In addition to re-bumping the value, I also went ahead and updated a few docs.

https://bugs.python.org/issue45711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 2 commits November 11, 2021 15:35
@brandtbucher
Re-bump magic number
f39a50e
@brandtbucher
Update docs
1691c46
@brandtbucher brandtbucher added the skip news label Nov 11, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 11, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 11, 2021
iritkatriel
iritkatriel approved these changes Nov 12, 2021
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I noticed the opcode doc omission yesterday too. It didn’t occur to me to put it in what’s new though. It seems like something users shouldn’t really care about. I guess the release manager can decide.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 12, 2021
@iritkatriel iritkatriel changed the title bpo-45711: Re-bump the magic number bpo-45711: Re-bump the magic number and update doc Nov 12, 2021
@iritkatriel
iritkatriel merged commit 8f1b71d into python:main Nov 12, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 12, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@brandtbucher remykarem
bpo-45711: Re-bump the magic number and update doc (pythonGH-29528)
fea8120
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@brandtbucher remykarem
bpo-45711: Re-bump the magic number and update doc (pythonGH-29528)
4fb5a67
@brandtbucher
brandtbucher deleted the fix-magic-number branch July 21, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brandtbucher @iritkatriel @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.