GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45292: Use raw strings for regex in tests by iritkatriel · Pull Request #29545 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 13, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This removes these warnings:

0:00:00 load avg: 0.39 [1/1] test_exception_group
/home/karthikeyan/stuff/python/cpython/Lib/test/test_exception_group.py:41: DeprecationWarning: invalid escape sequence '('
MSG = 'second argument (exceptions) must be a sequence'
/home/karthikeyan/stuff/python/cpython/Lib/test/test_exception_group.py:47: DeprecationWarning: invalid escape sequence '('
MSG = 'second argument (exceptions) must be a non-empty sequence'
/home/karthikeyan/stuff/python/cpython/Lib/test/test_exception_group.py:52: DeprecationWarning: invalid escape sequence '('
MSG = ('Item [0-9]+ of second argument (exceptions)'

https://bugs.python.org/issue45292

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-45292: Use raw strings for regex in tests
68361d3
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 13, 2021
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Nov 13, 2021
@iritkatriel
iritkatriel requested a review from tirkarthi November 13, 2021 14:07
@iritkatriel iritkatriel added the skip news label Nov 13, 2021
tirkarthi
tirkarthi approved these changes Nov 16, 2021
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 16, 2021
@tirkarthi
tirkarthi merged commit 8b06d01 into python:main Nov 16, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 16, 2021
@iritkatriel

iritkatriel commented Nov 16, 2021

Copy link
Copy Markdown
Member Author

Thank you @tirkarthi .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@iritkatriel remykarem
bpo-45292: Use raw strings for regex in tests (pythonGH-29545)
853325b
@iritkatriel iritkatriel mentioned this pull request Apr 10, 2022
Implement PEP 654: Exception Groups #89455
Closed
@iritkatriel
iritkatriel deleted the regex branch July 25, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @tirkarthi @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.