GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45738: Fix computation of error location for invalid continuation characters in the parser by pablogsal · Pull Request #29550 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 14, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner November 14, 2021 00:03
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 14, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 14, 2021
@pablogsal pablogsal added needs backport to 3.9 labels Nov 14, 2021
@pablogsal
pablogsal force-pushed the bpo-45738 branch 2 times, most recently from 2ee2af1 to f9fc733 Compare November 14, 2021 00:15
@pablogsal
bpo-45738: Fix computation of error location for invalid continuation
a6ef7b9 
characters in the parser
@pablogsal
pablogsal force-pushed the bpo-45738 branch from f9fc733 to a6ef7b9 Compare November 14, 2021 00:19
@pablogsal
pablogsal merged commit 25835c5 into python:main Nov 14, 2021
@pablogsal
pablogsal deleted the bpo-45738 branch November 14, 2021 01:06
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 14, 2021
@miss-islington

miss-islington commented Nov 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2021
@pablogsal @miss-islington
bpo-45738: Fix computation of error location for invalid continuation (…
2798af4 
…pythonGH-29550)

characters in the parser
(cherry picked from commit 25835c5)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington

miss-islington commented Nov 14, 2021

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 25835c518aa7446f3680b62c1fb43827e0f190d9 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned pablogsal Nov 14, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 14, 2021
@bedevere-bot

bedevere-bot commented Nov 14, 2021

Copy link
Copy Markdown

GH-29551 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 14, 2021
@pablogsal
bpo-45738: Fix computation of error location for invalid continuation (…
3f80c14 
…pythonGH-29550)

characters in the parser

(cherry picked from commit 25835c5)
@bedevere-bot

bedevere-bot commented Nov 14, 2021

Copy link
Copy Markdown

GH-29552 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 14, 2021
miss-islington added a commit that referenced this pull request Nov 14, 2021
@miss-islington @pablogsal
bpo-45738: Fix computation of error location for invalid continuation (…
bf26a6d 
…GH-29550)

characters in the parser
(cherry picked from commit 25835c5)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Nov 14, 2021
@pablogsal
bpo-45738: Fix computation of error location for invalid continuation…
142fcb4 
… characters in the parser (GH-29550) (GH-29552)

(cherry picked from commit 25835c5)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@pablogsal remykarem
bpo-45738: Fix computation of error location for invalid continuation (…
3da8dc5 
…pythonGH-29550)

characters in the parser
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@pablogsal remykarem
bpo-45738: Fix computation of error location for invalid continuation (…
0d32ef6 
…pythonGH-29550)

characters in the parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.