GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45573: Use Makefile's dependencies in setup.py (GH-29559) by tiran · Pull Request #29559 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 14, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

setup.py now reads MODULE_{name}_DEPS from Makefile to populate
an extension's depends field.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tiran
bpo-45573: Use Makefile's dependencies in setup.py
2df56e3
setup.py now reads ``MODULE_{name}_DEPS`` from ``Makefile`` to populate
an extension's depends field.

Signed-off-by: Christian Heimes <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 14, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 14, 2021
@tiran tiran added the skip news label Nov 14, 2021
erlend-aasland
erlend-aasland approved these changes Nov 14, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tiran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tiran tiran changed the title bpo-45573: Use Makefile's dependencies in setup.py bpo-45573: Use Makefile's dependencies in setup.py (GH-29559) Nov 14, 2021
@tiran
tiran merged commit c399786 into python:main Nov 14, 2021
@tiran
tiran deleted the bpo-45573-deps branch November 14, 2021 19:55
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 14, 2021
@bedevere-bot

bedevere-bot commented Nov 14, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit c399786.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/1196) and take a look at the build logs.
  4. Check if the failure is related to this commit (c399786) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/1196

Failed tests:

  • test_signal

Failed subtests:

  • test_stress_modifying_handlers - test.test_signal.StressTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

  • test_tools: 4 min 15 sec
  • test_concurrent_futures: 3 min 8 sec
  • test_multiprocessing_spawn: 2 min 13 sec
  • test_shelve: 1 min 50 sec
  • test_peg_generator: 1 min 44 sec
  • test_mailbox: 1 min 35 sec
  • test_tokenize: 1 min 27 sec
  • test_multiprocessing_forkserver: 1 min 25 sec
  • test_multiprocessing_fork: 1 min 14 sec
  • test_largefile: 1 min 14 sec

1 test failed:
test_signal

20 tests skipped:
test_devpoll test_epoll test_gdb test_idle test_ioctl test_kqueue
test_msilib test_smtpnet test_ssl test_startfile test_tcl test_tix
test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_signal

Total duration: 23 min 4 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_198512f4'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_37049669'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_signal.py", line 1334, in test_stress_modifying_handlers
    self.assertGreater(num_received_signals, 0)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 not greater than 0


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_1fd3d4e7'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45573: Use Makefile's dependencies in setup.py (pythonGH-29559)
906c843
@tiran tiran mentioned this pull request Jan 22, 2023
Use pkg-config autoconf macros to detect flags for Modules/Setup #89736
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @bedevere-bot @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.