GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45837: Properly deprecate turtle.RawTurtle.settiltangle by hugovk · Pull Request #29618 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Nov 18, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

turtle's settiltangle was deprecated in Python 3.1, according to docs:

Deprecated since version 3.1.

And the reason:

Turtle.tiltangle() has been enhanced in functionality: it now can be used to get or set the tiltangle. Turtle.settiltangle() has been deprecated.

However, in docstrings, tiltangle was accidentally commented as deprecated:

Deprecated since Python 3.1

Neither tiltangle nor settiltangle raise DeprecationWarnings.

So let's:

  • Correct tiltangle's docstring to say it's not really deprecated
  • Update settiltangle's docstring to say it's deprecated
  • Add a DeprecationWarning to settiltangle
  • Internally call self.tiltangle instead of self.settiltangle

BPO references:

  • 2009 https://bugs.python.org/issue5923 - when settiltangle was originally deprecated, with rationale.

  • 2010 https://bugs.python.org/issue7888 - the deprecation mixup was discovered and apparently corrected in py3k and release31-maint. I've not done the SCM archaeology to discover why this didn't make it through!

  • 2020 https://bugs.python.org/issue41165 - both mentioned as deprecated, discrepancy not noted.

https://bugs.python.org/issue45837

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 18, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 18, 2021
@hugovk
bpo-45837: Properly deprecate turtle.RawTurtle.settiltangle
10809f3
@hugovk
hugovk force-pushed the turtle-deprecations branch from c145b3b to 10809f3 Compare November 18, 2021 14:00
@ambv
ambv merged commit c94664c into python:main Nov 18, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Nov 18, 2021
@ambv

ambv commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

@hugovk would be great if you created a 3.10 and 3.9 PR that only clarifies in its docstring that tiltangle is not in fact deprecated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
hugovk deleted the turtle-deprecations branch November 18, 2021 19:38
This was referenced Nov 18, 2021
[3.10] bpo-45837: Note tiltangle is not deprecated, it's really settiltangle #29629
Merged
[3.9] bpo-45837: Note tiltangle is not deprecated, it's really settiltangle #29630
Merged
@hugovk

hugovk commented Nov 18, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Sure, please see #29629 and #29630. Do they need news entries?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

No, they don't. Thanks, Hugo! All merged.

hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@hugovk remykarem
bpo-45837: Properly deprecate turtle.RawTurtle.settiltangle (pythonGH…
99990f2
…-29618)
@hugovk hugovk mentioned this pull request Apr 23, 2022
Fix typo in turtle deprecation warning and use warnings._deprecated #91862
Merged
@hugovk hugovk mentioned this pull request May 24, 2023
Remove deprecated turtle.RawTurtle.settiltangle method #104876
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @ambv @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.