GeezerVison is showing github.com — bpo-45837: Properly deprecate turtle.RawTurtle.settiltangle by hugovk · Pull Request #29618 · python/cpython
Conversation
hugovk
commented
Nov 18, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
turtle's settiltangle was deprecated in Python 3.1, according to docs:
Deprecated since version 3.1.
And the reason:
Turtle.tiltangle() has been enhanced in functionality: it now can be used to get or set the tiltangle. Turtle.settiltangle() has been deprecated.
However, in docstrings, tiltangle was accidentally commented as deprecated:
Deprecated since Python 3.1
Neither tiltangle nor settiltangle raise DeprecationWarnings.
So let's:
- Correct
tiltangle's docstring to say it's not really deprecated
- Update
settiltangle's docstring to say it's deprecated
- Add a
DeprecationWarning to settiltangle
- Internally call
self.tiltangle instead of self.settiltangle
BPO references:
https://bugs.python.org/issue45837
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@hugovk would be great if you created a 3.10 and 3.9 PR that only clarifies in its docstring that tiltangle is not in fact deprecated.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 18, 2021
hugovk
commented
Nov 18, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Sure, please see #29629 and #29630. Do they need news entries?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
No, they don't. Thanks, Hugo! All merged.
|
hugovk reacted with rocket emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|