GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (GH-29642) by tiran · Pull Request #29642 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 19, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD
83ebd5d
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 19, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 19, 2021
@tiran

tiran commented Nov 19, 2021

Copy link
Copy Markdown
Member Author 
$ ./configure -C --without-builtin-hashlib-hashes
$ make clean
$ make
...
The following modules found by detect_modules() in setup.py have not
been built, they are *disabled* by configure:
_blake2               _md5                  _sha1              
_sha256               _sha3                 _sha512            
...
$ ./python -c "import _sha1"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named '_sha1'
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Nov 19, 2021
View reviewed changes
Comment thread Modules/Setup.stdlib.in
Comment on lines +41 to +46
@MODULE__MD5_TRUE@_md5 md5module.c
@MODULE__SHA1_TRUE@_sha1 sha1module.c
@MODULE__SHA256_TRUE@_sha256 sha256module.c
@MODULE__SHA512_TRUE@_sha512 sha512module.c
@MODULE__SHA3_TRUE@_sha3 _sha3/sha3module.c
@MODULE__BLAKE2_TRUE@_blake2 _blake2/blake2module.c _blake2/blake2b_impl.c _blake2/blake2s_impl.c

@erlend-aasland erlend-aasland Nov 19, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the "old" entries in Modules/Setup?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Nov 19, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules/Setup.stdlib is not used yet. I like to get all modules into the new setup file and then we can decide what do do about the old setup file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
erlend-aasland
erlend-aasland approved these changes Nov 19, 2021
View reviewed changes
@tiran tiran changed the title bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (GH-29642) Nov 19, 2021
@tiran
tiran merged commit c8c21bd into python:main Nov 19, 2021
@tiran
tiran deleted the bpo-45847-hashes branch November 19, 2021 19:20
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 19, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (pythonGH…
e35adf6 
…-29642)
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.