GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) by tiran · Pull Request #29644 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 19, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-45847: Port _scproxy to PY_STDLIB_MOD
22f07be
@tiran
tiran requested a review from ned-deily November 19, 2021 21:23
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 19, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 19, 2021
@tiran

tiran commented Nov 19, 2021

Copy link
Copy Markdown
Member Author

On macOS, the Makefile should contain:

MODULE__SCPROXY=yes
MODULE__SCPROXY_CFLAGS=
MODULE__SCPROXY_LDFLAGS=-framework SystemConfiguration -framework CoreFoundation

and setup.py should pick up the settings automatically.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added the skip news label Nov 19, 2021
ned-deily
ned-deily approved these changes Nov 19, 2021
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 19, 2021
@tiran
tiran marked this pull request as ready for review November 20, 2021 09:18
@tiran tiran changed the title bpo-45847: Port _scproxy to PY_STDLIB_MOD bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) Nov 20, 2021
@tiran
tiran merged commit 5596909 into python:main Nov 20, 2021
@tiran
tiran deleted the bpo-45847-scproxy branch November 20, 2021 09:18
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 20, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45847: Port _scproxy to PY_STDLIB_MOD (pythonGH-29644)
6de7f74
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @ned-deily @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.