GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port fcntl to Py_STDLIB_MOD (GH-29696) by erlend-aasland · Pull Request #29696 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-45847: Port fcntl to Py_STDLIB_MOD_SIMPLE
dbf9be7
@erlend-aasland
erlend-aasland requested a review from tiran November 22, 2021 10:01
@erlend-aasland

erlend-aasland commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

I added checks for sys/ioctl.h and fcntl.h. Probably not needed, OTOH it doesn't hurt either. Also simplified some of the AC checks for fcntl.
tiran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran reviewed Nov 22, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland @tiran
Address review: consistent formatting
e1e1e2a 
Co-authored-by: Christian Heimes <[email protected]>
@erlend-aasland erlend-aasland added the skip news label Nov 22, 2021
tiran
tiran approved these changes Nov 22, 2021
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Nov 22, 2021
@erlend-aasland erlend-aasland closed this Nov 22, 2021
@erlend-aasland erlend-aasland reopened this Nov 22, 2021
@erlend-aasland

erlend-aasland commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

Reopen to retrigger flakey asyncio test on windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland added 2 commits November 22, 2021 11:35
Erlend E. Aasland
Regen configure
25b5160
Erlend E. Aasland
Merge branch 'main' into ac-simple-mods/fcntl
b143948
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@bedevere-bot

bedevere-bot commented Nov 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit b143948 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
tiran
tiran approved these changes Nov 22, 2021
View reviewed changes
@tiran tiran changed the title bpo-45847: Port fcntl to Py_STDLIB_MOD bpo-45847: Port fcntl to Py_STDLIB_MOD (GH-29696) Nov 22, 2021
@tiran
tiran merged commit 5b946ca into python:main Nov 22, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 22, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland @tiran remykarem
bpo-45847: Port fcntl to Py_STDLIB_MOD (pythonGH-29696)
322a8b0 
Co-authored-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
jefferyto
jefferyto reviewed May 25, 2023
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the ac-simple-mods/fcntl branch May 25, 2023 07:11
@erlend-aasland erlend-aasland mentioned this pull request Jun 2, 2023
gh-90005: Don't link with libbsd if not needed #105236
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 2, 2023
@erlend-aasland
pythongh-90005: Don't link with libbsd if not needed
20add4f 
Restore pre pythongh-29696 behaviour
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
@erlend-aasland
gh-90005: Don't link with libbsd if not needed (#105236)
e01c4de 
The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.12] pythongh-90005: Don't link with libbsd if not needed (python#1…
bdd2b89 
…05236)

The regression was introduced with commit 5b946ca.
Restore pre pythongh-29696 behaviour.
This was referenced Jun 6, 2023
[3.11] gh-90005: Don't link with libbsd if not needed (#105236) #105359
Merged
[3.12] gh-90005: Don't link with libbsd if not needed (#105236) #105360
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.11] pythongh-90005: Don't link with libbsd if not needed (python#1…
a8c9f08 
…05236)

The regression was introduced with commit 5b946ca.
Restore pre pythongh-29696 behaviour.
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.12] gh-90005: Don't link with libbsd if not needed (#105236) (#105360
6f3a4fd 
)

The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.11] gh-90005: Don't link with libbsd if not needed (#105236) (#105359
b8d3bb7 
)

The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@jefferyto jefferyto jefferyto left review comments
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @jefferyto @tiran
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.