GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) by tiran · Pull Request #29699 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran tiran added the skip news label Nov 22, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 22, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 22, 2021
@tiran
tiran force-pushed the bpo-45847-nis branch from cae0044 to 3043b76 Compare November 22, 2021 11:12
@tiran
tiran marked this pull request as ready for review November 22, 2021 11:17
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@bedevere-bot

bedevere-bot commented Nov 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 3043b762c9cbcb0500de5d9e19cb4139e1457d40 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@tiran tiran changed the title bpo-45847: Port nis module to PY_STDLIB_MOD_SIMPLE bpo-45847: Port nis module to PY_STDLIB_MOD Nov 22, 2021
erlend-aasland
erlend-aasland reviewed Nov 22, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@bedevere-bot

bedevere-bot commented Nov 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit c6c687160b4ad830a55235581e6515f36ffe27cd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@tiran
tiran requested a review from erlend-aasland November 22, 2021 13:29
tiran added 2 commits November 22, 2021 14:53
@tiran
bpo-45847: Port nis module to PY_STDLIB_MOD_SIMPLE
d592dd9 
Signed-off-by: Christian Heimes <[email protected]>
@tiran
Restore LIBS
b73b169
@tiran
tiran force-pushed the bpo-45847-nis branch from c6c6871 to b73b169 Compare November 22, 2021 13:54
tiran
tiran commented Nov 22, 2021
View reviewed changes
Comment thread Modules/Setup.stdlib.in
@MODULE__RANDOM_TRUE@_random _randommodule.c
@MODULE__TYPING_TRUE@_typing _typingmodule.c
@MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters __xxsubinterpretersmodule.c
@MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters _xxsubinterpretersmodule.c

@tiran tiran Nov 22, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland I'm sneaking in this typo fix, too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
erlend-aasland
erlend-aasland requested changes Nov 22, 2021
View reviewed changes
Comment thread configure.ac

PY_STDLIB_MOD([_decimal], [], [], [$LIBMPDEC_CFLAGS], [$LIBMPDEC_LDFLAGS])
PY_STDLIB_MOD([nis],
[], [test "$have_nis" = yes -a "$ac_cv_header_rpc_rpc_h" = yes],

@erlend-aasland erlend-aasland Nov 22, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS, header check for rpc/rpc.h is missing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Nov 22, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's right there:

AS_VAR_IF([have_nis], [yes], [
  WITH_SAVE_ENV([
    CPPFLAGS="$LIBNSL_CFLAGS $CFLAGS"
    AC_CHECK_HEADERS([rpc/rpc.h])
  ])
])

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Nov 22, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran reacted with laugh emoji
All reactions
  • 😄 1 reaction
erlend-aasland
erlend-aasland approved these changes Nov 22, 2021
View reviewed changes
@tiran tiran changed the title bpo-45847: Port nis module to PY_STDLIB_MOD bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) Nov 22, 2021
@tiran
tiran merged commit c6dec7e into python:main Nov 22, 2021
@tiran
tiran deleted the bpo-45847-nis branch November 22, 2021 14:18
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 22, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45847: Port nis module to PY_STDLIB_MOD (pythonGH-29699)
f01ddd5
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @bedevere-bot @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.