GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port audioop, _csv, and _posixsubprocess to PY_STDLIB_MOD_SIMPLE by erlend-aasland · Pull Request #29705 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 22, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45847

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-45847: Port audioop, _csv, and _posixsubprocess to PY_STDLIB_MOD_…
79fc63c 
…SIMPLE
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 22, 2021
@erlend-aasland
erlend-aasland requested a review from tiran November 22, 2021 14:06
@bedevere-bot bedevere-bot added the awaiting review label Nov 22, 2021
@erlend-aasland erlend-aasland added skip news and removed awaiting review labels Nov 22, 2021
tiran
tiran approved these changes Nov 22, 2021
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Nov 22, 2021
tiran
tiran reviewed Nov 22, 2021
View reviewed changes
Comment thread Modules/Setup.stdlib.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Adress review: move _posixsubprocess
3938a58
tiran
tiran approved these changes Nov 22, 2021
View reviewed changes
@tiran tiran added the 🤖 automerge label Nov 22, 2021
@miss-islington

miss-islington commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .
erlend-aasland reacted with thumbs down emoji
All reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 22, 2021

Copy link
Copy Markdown
Member

Miss Islington is having a bad day.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit eee683c into python:main Nov 22, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 22, 2021
@erlend-aasland
erlend-aasland deleted the ac-simple-mods/part5 branch November 22, 2021 14:43
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland remykarem
bpo-45847: Port audioop, _csv, and _posixsubprocess to PY_STDLIB_MOD_…
46dc14f 
…SIMPLE (pythonGH-29705)

Automerge-Triggered-By: GH:tiran
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @miss-islington @tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.