GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port _socket to PY_STDLIB_MOD (GH-29713) by erlend-aasland · Pull Request #29713 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-45847: Port socket to PY_STDLIB_MOD_SIMPLE
d5397d3
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 22, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 22, 2021
@erlend-aasland
erlend-aasland requested a review from tiran November 22, 2021 18:00
@erlend-aasland erlend-aasland added the skip news label Nov 22, 2021
@erlend-aasland

erlend-aasland commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

I'll run this through the buildbots after you've had a look, @tiran.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran reviewed Nov 22, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Address review: remove checks
e45604c
@erlend-aasland
erlend-aasland requested a review from tiran November 22, 2021 20:48
Erlend E. Aasland
Also remove netinet/in.h check
7d506ca
tiran
tiran approved these changes Nov 23, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 23, 2021
@tiran tiran changed the title bpo-45847: Port _socket to PY_STDLIB_MOD bpo-45847: Port _socket to PY_STDLIB_MOD (GH-29713) Nov 23, 2021
@tiran
tiran merged commit d82f2ca into python:main Nov 23, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 23, 2021
@erlend-aasland
erlend-aasland deleted the ac-socket branch November 23, 2021 20:30
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland remykarem
bpo-45847: Port _socket to PY_STDLIB_MOD (pythonGH-29713)
f382c2f
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.