GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Fix _crypt detection on Ubuntu (GH-29743) by tiran · Pull Request #29743 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 24, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For some reason the linker check does not work on Ubuntu if -lcrypt
is in LDFLAGS instead of LIBS.

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-45847: Fix _crypt detection on Ubuntu
fe1aba9 
For some reason the linker check does not work on Ubuntu if ``-lcrypt``
is in ``LDFLAGS`` instead of ``LIBS``.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 24, 2021
@tiran
tiran requested a review from erlend-aasland November 24, 2021 09:20
@bedevere-bot bedevere-bot added the awaiting core review label Nov 24, 2021
@tiran tiran added the skip news label Nov 24, 2021
@tiran tiran changed the title bpo-45847: Fix _crypt detection on Ubuntu bpo-45847: Fix _crypt detection on Ubuntu (GH-29743) Nov 24, 2021
@tiran
tiran merged commit 64c3807 into python:main Nov 24, 2021
@tiran
tiran deleted the bpo-45847-crypt2 branch November 24, 2021 09:47
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 24, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45847: Fix _crypt detection on Ubuntu (pythonGH-29743)
248f254
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.