GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45881: Use CC from env first for cross building (GH-29752) by tiran · Pull Request #29752 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 24, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

setup.py now uses CC from environment first to discover multiarch
and cross compile paths. The sysconfig variable contains the value for
the build host.

The patch also re-arranges set_compiler_executables,
configure_compiler, and init_inc_lib_dirs to make the code
easier to follow.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45881

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Nov 24, 2021
@tiran tiran added needs backport to 3.9 and removed awaiting core review labels Nov 24, 2021
@tiran
bpo-45881: Use CC from env first for cross building
0719057 
``setup.py`` now uses ``CC`` from environment first to discover multiarch
and cross compile paths. The sysconfig variable contains the value for
the build host.

The patch also re-arranges ``set_compiler_executables``,
``configure_compiler``, and ``init_inc_lib_dirs`` to make the code
easier to follow.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
tiran force-pushed the bpo-45881-cross-cc branch from acc610b to 0719057 Compare November 24, 2021 16:47
brettcannon
brettcannon approved these changes Nov 24, 2021
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Nov 24, 2021
@tiran tiran changed the title bpo-45881: Use CC from env first for cross building bpo-45881: Use CC from env first for cross building (GH-29752) Nov 24, 2021
@tiran
tiran merged commit b30bf45 into python:main Nov 24, 2021
@tiran
tiran deleted the bpo-45881-cross-cc branch November 24, 2021 17:53
@miss-islington

miss-islington commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 24, 2021
@miss-islington

miss-islington commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b30bf4520ae9d6e7eca09d812dd8a86c020b9202 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran Nov 24, 2021
@miss-islington

miss-islington commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b30bf4520ae9d6e7eca09d812dd8a86c020b9202 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran added a commit to tiran/cpython that referenced this pull request Nov 24, 2021
@tiran
[3.10] bpo-45881: Use CC from env first for cross building (pythonGH-…
e6b0c8a 
…29752).

(cherry picked from commit b30bf45)

Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit to tiran/cpython that referenced this pull request Nov 24, 2021
@tiran
[3.9] [3.10] bpo-45881: Use CC from env first for cross building (pyt…
ad6981a 
…honGH-29752).

(cherry picked from commit b30bf45)

Co-authored-by: Christian Heimes <[email protected]>.
(cherry picked from commit e6b0c8a)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 24, 2021

Copy link
Copy Markdown

GH-29754 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 24, 2021
@tiran tiran mentioned this pull request Nov 25, 2021
bpo-40280: Add wasm cross build targets (GH-29771) #29771
Merged
tiran added a commit that referenced this pull request Nov 25, 2021
@tiran
[3.9] bpo-45881: Use CC from env first for cross building (GH-29752) (G…
cd6d257 
…H-29754)

Co-authored-by: Christian Heimes <[email protected]>.
Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit that referenced this pull request Nov 27, 2021
@tiran
[3.10] bpo-45881: Use CC from env first for cross building (GH-29752). (
545aebd 
GH-29753)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 27, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.10 has failed when building commit 545aebd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/690/builds/488) and take a look at the build logs.
  4. Check if the failure is related to this commit (545aebd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/690/builds/488

Summary of the results of the build (if available):

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 504

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45881: Use CC from env first for cross building (pythonGH-29752)
5463c73
@tiran tiran mentioned this pull request Apr 10, 2022
Cross compiling on Linux is untested, undocumented, and broken #90039
Closed
@terryjreedy terryjreedy removed the needs backport to 3.10 label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @miss-islington @bedevere-bot @brettcannon @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.