GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41498: Fix build on platforms without sigset_t (GH-29770) by tiran · Pull Request #29770 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Python now compiles on platforms without sigset_t. Several functions
in :mod:signal are not available when sigset_t is missing.

Based on patch by Roman Yurchak for pyodide.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue41498

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rth reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tiran tiran added needs backport to 3.9 labels Nov 25, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 25, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 25, 2021
@tiran
bpo-41498: Fix build on platforms without sigset_t
691eef3 
Python now compiles on platforms without ``sigset_t``. Several functions
in :mod:`signal` are not available when ``sigset_t`` is missing.

Based on patch by Roman Yurchak for pyodide.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
tiran force-pushed the bpo-41498-sigset_t branch from 86474f4 to 691eef3 Compare November 25, 2021 10:25
pablogsal
pablogsal approved these changes Nov 25, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 25, 2021
@pablogsal

pablogsal commented Nov 25, 2021

Copy link
Copy Markdown
Member

It would be good to have a buildbot validating these but is simple enough to go ahead
tiran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 25, 2021

Copy link
Copy Markdown
Member Author

It would be good to have a buildbot validating these but is simple enough to go ahead

We'll get some smoke tests for the problem when we have wasm builds.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-41498: Fix build on platforms without sigset_t bpo-41498: Fix build on platforms without sigset_t (GH-29770) Nov 25, 2021
@tiran
tiran merged commit dc19e86 into python:main Nov 25, 2021
@tiran
tiran deleted the bpo-41498-sigset_t branch November 25, 2021 11:28
@miss-islington

miss-islington commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 25, 2021
@miss-islington

miss-islington commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dc19e8698327cae3d6274b73c135375955f1d0d0 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran Nov 25, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 25, 2021
@bedevere-bot

bedevere-bot commented Nov 25, 2021

Copy link
Copy Markdown

GH-29773 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2021
@tiran @miss-islington
bpo-41498: Fix build on platforms without sigset_t (pythonGH-29770)
e902894 
(cherry picked from commit dc19e86)

Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit to tiran/cpython that referenced this pull request Nov 25, 2021
@tiran
[3.9] bpo-41498: Fix build on platforms without sigset_t (pythonGH-29770
bd7e38f 
).

(cherry picked from commit dc19e86)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 25, 2021

Copy link
Copy Markdown

GH-29774 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 25, 2021
miss-islington added a commit that referenced this pull request Nov 25, 2021
@miss-islington
[3.10] bpo-41498: Fix build on platforms without sigset_t (GH-29770) (G…
632d589 
…H-29773)

(cherry picked from commit dc19e86)


Co-authored-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran
tiran added a commit that referenced this pull request Nov 25, 2021
@tiran
[3.9] bpo-41498: Fix build on platforms without sigset_t (GH-29770) (G…
71b4147 
…H-29774)

Co-authored-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this pull request Nov 25, 2021
bpo-40280: Add wasm cross build targets (GH-29771) #29771
Merged
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-41498: Fix build on platforms without sigset_t (pythonGH-29770)
f5b277c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.