GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: Improve example for urlparse() by cclauss · Pull Request #29816 · python/cpython

Conversation

@cclauss

@cclauss cclauss commented Nov 27, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

http://docs.python.org:80/3/library/urllib.parse.html?highlight=params#url-parsing

Provide a more complete URL example to demonstrate the query and fragment members of ParseResult. Today's visitors to these docs are more used to complex URLs so it is better to quickly show them how urlparse() will segment the various parts including query and fragment.

Signed-off-by: Christian Clauss [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cclauss
docs: Improve example for urlparse
1d845e2 
Signed-off-by: Christian Clauss <[email protected]>
@cclauss
cclauss force-pushed the better-examples-for-urlparse branch from c922c31 to 1d845e2 Compare November 28, 2021 11:17
cclauss added 4 commits November 28, 2021 16:41
@cclauss
fixup! +NORMALIZE_WHITESPACE
4cb40c6
@cclauss
fixup! +NORMALIZE_WHITESPACE
44c80b2
@cclauss
fixup! Normalize whitespace
b57c554
@cclauss
fixup! Shorten the URL to work in doctest
3f168a8
asvetlov
asvetlov approved these changes Dec 2, 2021
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting merge label Dec 2, 2021
@asvetlov asvetlov added skip issue skip news needs backport to 3.9 labels Dec 2, 2021
@asvetlov
asvetlov merged commit 226d22f into python:main Dec 2, 2021
@miss-islington

miss-islington commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Thanks @cclauss for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 2, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2021
@cclauss @miss-islington
docs: Improve example for urlparse() (pythonGH-29816)
e5b1078 
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Dec 2, 2021
@bedevere-bot

bedevere-bot commented Dec 2, 2021

Copy link
Copy Markdown

GH-29888 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2021
@cclauss @miss-islington
docs: Improve example for urlparse() (pythonGH-29816)
0ddc37c 
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 2, 2021

Copy link
Copy Markdown

GH-29889 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 2, 2021
@cclauss
cclauss deleted the better-examples-for-urlparse branch December 2, 2021 09:39
asvetlov pushed a commit that referenced this pull request Dec 2, 2021
@miss-islington @cclauss
docs: Improve example for urlparse() (GH-29816) (GH-29889)
0003d57 
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <[email protected]>
asvetlov pushed a commit that referenced this pull request Dec 2, 2021
@miss-islington @cclauss
docs: Improve example for urlparse() (GH-29816) (GH-29888)
eac07e5 
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <[email protected]>
@domdfcoding domdfcoding mentioned this pull request Apr 20, 2022
urllib.parse.urlparse output named tuples description is wrong for Python 3.9 and 3.10 #91708
Closed
domdfcoding added a commit to domdfcoding/cpython that referenced this pull request Apr 21, 2022
@domdfcoding
Revert changes to table from pythonGH-29816
4400c1f
domdfcoding added a commit to domdfcoding/cpython that referenced this pull request Apr 20, 2023
@domdfcoding
Revert changes to table from pythonGH-29816
2513476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@cclauss @miss-islington @bedevere-bot @asvetlov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.