GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias (GH-29294) by miss-islington · Pull Request #29926 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 5, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 446be16)

Co-authored-by: Serhiy Storchaka [email protected]

https://bugs.python.org/issue45663

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
c6ef4d8 
… types.GenericAlias (pythonGH-29294)

(cherry picked from commit 446be16)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner December 5, 2021 20:43
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 5, 2021
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2021
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias #29294
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Dec 5, 2021
serhiy-storchaka
serhiy-storchaka approved these changes Dec 5, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 5, 2021
@miss-islington

miss-islington commented Dec 5, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 1905071 into python:3.9 Dec 5, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 5, 2021
@miss-islington
miss-islington deleted the backport-446be16-3.9 branch December 5, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.