GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias by serhiy-storchaka · Pull Request #29294 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 28, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45663

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
3707b67 
… types.GenericAlias
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.9 labels Oct 28, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from ericvsmith as a code owner October 28, 2021 20:14
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 28, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Oct 28, 2021
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@bedevere-bot

bedevere-bot commented Nov 2, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 3707b67 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@github-actions

github-actions Bot commented Dec 3, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 3, 2021
@serhiy-storchaka
Merge branch 'main' into is_dataclass-genericalias
0bb6708
@serhiy-storchaka
serhiy-storchaka merged commit 446be16 into python:main Dec 5, 2021
@miss-islington

miss-islington commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2021
@serhiy-storchaka @miss-islington
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
66ad403 
… types.GenericAlias (pythonGH-29294)

(cherry picked from commit 446be16)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka deleted the is_dataclass-genericalias branch December 5, 2021 20:42
@bedevere-bot

bedevere-bot commented Dec 5, 2021

Copy link
Copy Markdown

GH-29925 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Dec 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2021
@serhiy-storchaka @miss-islington
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
c6ef4d8 
… types.GenericAlias (pythonGH-29294)

(cherry picked from commit 446be16)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 5, 2021
@bedevere-bot

bedevere-bot commented Dec 5, 2021

Copy link
Copy Markdown

GH-29926 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Dec 5, 2021
@miss-islington @serhiy-storchaka
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
abceb66 
… types.GenericAlias (GH-29294)

(cherry picked from commit 446be16)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Dec 5, 2021
@miss-islington @serhiy-storchaka
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
1905071 
… types.GenericAlias (GH-29294)

(cherry picked from commit 446be16)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time. type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.