GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45711: Do not push/pop traceback on stack as part of exc_info by iritkatriel · Pull Request #29968 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-45711: Do not PUSH/POP traceback to the stack as part of exc_info
98085fe
@iritkatriel
iritkatriel requested a review from markshannon as a code owner December 7, 2021 17:47
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 7, 2021
@iritkatriel
iritkatriel marked this pull request as draft December 7, 2021 17:47
@iritkatriel

iritkatriel commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

Marked as draft because I still need to update the opcodes documentation
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel commented Dec 7, 2021
View reviewed changes
Comment thread Python/ceval.c

assert(exc_info->exc_value);
if (exc_info->exc_value != Py_None) {
exc_info->exc_traceback = PyException_GetTraceback(exc_info->exc_value);

@iritkatriel iritkatriel Dec 7, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next step is to remove exc_traceback from exc_info and then this will not be here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@bedevere-bot

bedevere-bot commented Dec 7, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 98085fe 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@iritkatriel
updated dis doc
4f57791
@iritkatriel
iritkatriel marked this pull request as ready for review December 7, 2021 18:15
@iritkatriel
iritkatriel requested a review from gvanrossum December 7, 2021 18:21
@iritkatriel

iritkatriel commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

This clashes with the except* branch, and I'd rather merge that one first and update this one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the DO-NOT-MERGE label Dec 7, 2021
@markshannon

markshannon commented Dec 8, 2021

Copy link
Copy Markdown
Member

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first.
Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first. Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

And that requires PR 29922.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev
arhadthedev requested changes Dec 8, 2021
View reviewed changes

@arhadthedev arhadthedev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing between tokens is strange.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 3 commits December 8, 2021 18:56
@iritkatriel
Merge remote-tracking branch 'upstream/main' into 45711-no-traceback-…
707369c 
…in-stack
@iritkatriel
Oleg's suggestions
f6b4c2a
@iritkatriel
more whitespace
2a5f1ff
@iritkatriel

iritkatriel commented Dec 15, 2021

Copy link
Copy Markdown
Member Author

Superseded by #30122
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel closed this Dec 15, 2021
@iritkatriel
iritkatriel deleted the 45711-no-traceback-in-stack branch January 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev requested changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @bedevere-bot @markshannon @arhadthedev @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.