GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — bpo-45711: Remove type and traceback from exc_info by iritkatriel · Pull Request #30122 · python/cpython Conversation
|
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9b04160 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
|
|
||
| /* number of items stored in the stack for each exception */ | ||
| #define PY_EXC_INFO_STACK_SIZE 1 |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary now?
I don't see why we would ever want to increase it, and I don't see how we could ever decrease it.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The name is probably weird now, but I think it helps readability to have a macro. If we remove this we should find another way to make the code (particularly in compile.c) clear about where exceptions are showing up. Figuring out where to use this macro was the hardest part of making this change (because when you get it wrong it just segfaults before you finish make regen-all).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
On second thought there is no point in a macro for this unless we all agree on some kind of convention because it probably won't be updated correctly when people make changes. So I'll remove it.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
This is great. 🍾 Removes code, should make any exception handling code faster and reduces stack consumption; the perfect combination. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Oleg Iarygin <[email protected]>
|
The windows test failure is unrelated File "D:\a\cpython\cpython\Lib\test\support_init_.py", line 197, in _force_run |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Excellent. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.