GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29655: Fix import start can leak a reference. by Carreau · Pull Request #301 · python/cpython

Conversation

@Carreau

@Carreau Carreau commented Feb 26, 2017

Copy link
Copy Markdown
Contributor

See http://bugs.python.org/issue29655

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Carreau
bpo-29655: Fix import start can leak a reference.
b338566
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 26, 2017
serhiy-storchaka
serhiy-storchaka approved these changes Feb 26, 2017
View reviewed changes
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels Feb 26, 2017
@serhiy-storchaka
serhiy-storchaka merged commit 160edb4 into python:master Feb 26, 2017
@Carreau
Carreau deleted the fix-bpo29655 branch February 27, 2017 16:22
@berkerpeksag

berkerpeksag commented Feb 27, 2017

Copy link
Copy Markdown
Member

Shouldn't this be documented in Misc/NEWS?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 27, 2017
@Carreau @berkerpeksag
bpo-29655: Fixed possible reference leaks in import *. (python#301)
8215abc 
Patch by Matthias Bussonnier.

(cherry picked from commit 160edb4)
@berkerpeksag berkerpeksag removed needs backport to 2.7 labels Feb 27, 2017
berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 27, 2017
@Carreau @berkerpeksag
bpo-29655: Fixed possible reference leaks in import *. (python#301)
a3b6af3 
Patch by Matthias Bussonnier.

(cherry picked from commit 160edb4)
@berkerpeksag berkerpeksag removed the needs backport to 3.5 label Feb 27, 2017
@serhiy-storchaka

serhiy-storchaka commented Feb 27, 2017

Copy link
Copy Markdown
Member

I'm not sure. This is hardly reproducible small leak. Unlikely it harms real applications.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag added a commit that referenced this pull request Feb 27, 2017
@berkerpeksag
bpo-29655: Fixed possible reference leaks in import *. (#301) (#348)
7accf20 
Patch by Matthias Bussonnier.

(cherry picked from commit 160edb4)
berkerpeksag added a commit that referenced this pull request Feb 27, 2017
@berkerpeksag
bpo-29655: Fixed possible reference leaks in import *. (#301) (#349)
0dadf56 
Patch by Matthias Bussonnier.

(cherry picked from commit 160edb4)
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 6, 2017
@Carreau @serhiy-storchaka
bpo-29655: Fixed possible reference leaks in import *. (python#301)
f02d84e 
Original patch by Matthias Bussonnier.
(cherry picked from commit 160edb4)
serhiy-storchaka added a commit that referenced this pull request Mar 8, 2017
@serhiy-storchaka
bpo-29655: Fixed possible reference leaks in import *. (#301) (#510)
9fbb65e 
Original patch by Matthias Bussonnier.
(cherry picked from commit 160edb4)
akruis added a commit to akruis/cpython that referenced this pull request Aug 11, 2021
@akruis
Stackless issue python#301: remove a superfluous comment in _asynciom…
a15cc35 
…odule.c
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump cachetools from 3.1.1 to 4.0.0 (#301)
5894e96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Carreau @berkerpeksag @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.