GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38415: Remove redundant AsyncContextDecorator.__call__ override from _AsyncG… by graingert · Pull Request #30233 · python/cpython

Conversation

@graingert

@graingert graingert commented Dec 23, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

…eneratorContextManager

#16667 was opened however was allowed to go stale while #20516 was created and then merged first.

This PR currently shows that the tests added in #16667 pass without the associated code change - but it might be cleaner to just do a plain revert and rely on the tests added in #20516

https://bugs.python.org/issue38415

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
remove redundant AsyncContextDecorator.__call__ override from _AsyncG…
0454323 
…eneratorContextManager
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 23, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 23, 2021
@graingert graingert changed the title remove redundant AsyncContextDecorator.__call__ override from _AsyncG… bpo-38415 remove redundant AsyncContextDecorator.__call__ override from _AsyncG… Dec 23, 2021
@blurb-it
📜🤖 Added by blurb_it.
f55afb2
@graingert
graingert marked this pull request as ready for review December 23, 2021 00:58
@graingert
graingert requested a review from 1st1 as a code owner December 23, 2021 00:58
graingert
graingert commented Dec 23, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2021-12-23-00-58-31.bpo-38415.NY5sUF.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Update Misc/NEWS.d/next/Library/2021-12-23-00-58-31.bpo-38415.NY5sUF.rst
0b6ee6b
graingert
graingert commented Dec 23, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2021-12-23-00-58-31.bpo-38415.NY5sUF.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Update Misc/NEWS.d/next/Library/2021-12-23-00-58-31.bpo-38415.NY5sUF.rst
1c350a6
@serhiy-storchaka serhiy-storchaka changed the title bpo-38415 remove redundant AsyncContextDecorator.__call__ override from _AsyncG… bpo-38415: Remove redundant AsyncContextDecorator.__call__ override from _AsyncG… Dec 26, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from ambv December 26, 2021 10:47
serhiy-storchaka
serhiy-storchaka reviewed Dec 26, 2021
View reviewed changes
Comment thread Lib/contextlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Dec 26, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/contextlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 26, 2021
raghavthind2005
raghavthind2005 approved these changes Jan 23, 2022
View reviewed changes
@serhiy-storchaka
Delete 2021-12-23-00-58-31.bpo-38415.NY5sUF.rst
462ae8b 
Since the change does not affect the user-visible behavior, a NEWS entry is not needed.
serhiy-storchaka
serhiy-storchaka approved these changes Feb 3, 2022
View reviewed changes
@graingert
graingert requested a review from serhiy-storchaka February 22, 2022 19:10
serhiy-storchaka
serhiy-storchaka approved these changes Feb 26, 2022
View reviewed changes
@serhiy-storchaka serhiy-storchaka added the skip news label Feb 26, 2022
@serhiy-storchaka
serhiy-storchaka merged commit b57dbe5 into python:main Feb 26, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 26, 2022
@graingert
graingert deleted the patch-3 branch February 26, 2022 12:05
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
@graingert @asvetlov
bpo-38415: Remove redundant AsyncContextDecorator.__call__ override f…
f7e538c 
…rom _AsyncGeneratorContextManager (GH-30233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@1st1 1st1 Awaiting requested review from 1st1
@ambv ambv Awaiting requested review from ambv
+1 more reviewer
@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@graingert @serhiy-storchaka @raghavthind2005 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.