GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-40296: Fix supporting generic aliases in pydoc by serhiy-storchaka · Pull Request #30253 · python/cpython

Conversation

serhiy-storchaka commented Dec 25, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue40296

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-40296: Fix supporting generic aliases in pydoc

51d3a2b

serhiy-storchaka added type-bug

An unexpected behavior, bug, or error

needs backport to 3.9 labels

Dec 25, 2021

the-knights-who-say-ni added the CLA signed label

Dec 25, 2021

bedevere-bot added the awaiting core review label

Dec 25, 2021

gvanrossum approved these changes

Jan 11, 2022

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry I took so long for the review!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Jan 11, 2022

raghavthind2005 approved these changes

Jan 18, 2022

View reviewed changes

gvanrossum commented Jan 18, 2022

Copy link

Copy Markdown

Member

@serhiy-storchaka If you still care please merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka commented Jan 18, 2022

Copy link

Copy Markdown

Member Author

Sorry, I was going to review it myself yet once and maybe add more tests if not all changes are covered.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 2 commits

March 17, 2022 10:49


          Merge branch 'main' into pydoc-generic-alias

6027d94


          Add more tests.

dd195b3

serhiy-storchaka commented Mar 17, 2022

Copy link

Copy Markdown

Member Author

Will merge after fixing pydoc tests (#31959) and adding some new tests.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into pydoc-generic-alias

3ab201c

serhiy-storchaka merged commit cd44afc into python:main

Mar 18, 2022

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Mar 18, 2022

serhiy-storchaka deleted the pydoc-generic-alias branch

March 18, 2022 09:05

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cd44afc573e2e2de8d7e5a9119c347373066cd10 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned serhiy-storchaka

Mar 18, 2022

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker cd44afc573e2e2de8d7e5a9119c347373066cd10 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added needs backport to 3.9 and removed needs backport to 3.9 labels

Mar 18, 2022

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cd44afc573e2e2de8d7e5a9119c347373066cd10 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Mar 18, 2022

Copy link

Copy Markdown

Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker cd44afc573e2e2de8d7e5a9119c347373066cd10 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Mar 18, 2022


          [3.10] bpo-40296: Fix supporting generic aliases in pydoc (pythonGH-3…

e279a2a

…0253).

(cherry picked from commit cd44afc)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Mar 18, 2022

Copy link

Copy Markdown

GH-31976 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Mar 18, 2022

serhiy-storchaka added a commit that referenced this pull request

Mar 18, 2022


          [3.10] bpo-40296: Fix supporting generic aliases in pydoc (GH-30253). (…

a5b7678

…GH-31976)

(cherry picked from commit cd44afc)

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 18, 2022


          [3.10] bpo-40296: Fix supporting generic aliases in pydoc (pythonGH-3…

a85f0cc

…0253). (pythonGH-31976)

(cherry picked from commit cd44afc)
(cherry picked from commit a5b7678)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka pushed a commit that referenced this pull request

Mar 19, 2022


          [3.9] bpo-40296: Fix supporting generic aliases in pydoc (GH-30253). (G…

e207d72

…H-31976) (GH-31981)

(cherry picked from commit cd44afc)
(cherry picked from commit a5b7678)

ksunden mentioned this pull request

Mar 25, 2022

TypeError raised by help(numpy.typing) numpy/numpy#21240

Closed

kernc mentioned this pull request

Apr 12, 2022

Getting exception with Python 3.9 and 0.9.2 pdoc3/pdoc#286

Open

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request

Jun 2, 2022


          [3.9] bpo-40296: Fix supporting generic aliases in pydoc (pythonGH-30253

0458b29

). (pythonGH-31976) (pythonGH-31981)

(cherry picked from commit cd44afc)
(cherry picked from commit a5b7678)

serhiy-storchaka removed the needs backport to 3.9 label

Nov 10, 2023

serhiy-storchaka removed their assignment

Nov 10, 2023

hauntsaninja mentioned this pull request

Jul 10, 2025

gh-136438: Make sure test.test_pydoc.test_pydoc pass with all optimization levels #136479

Merged

Reviewers

gvanrossum

gvanrossum approved these changes

+1 more reviewer

raghavthind2005

raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Dec 25, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum commented Jan 18, 2022

Uh oh!

serhiy-storchaka commented Jan 18, 2022

Uh oh!

serhiy-storchaka commented Mar 17, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

miss-islington commented Mar 18, 2022

Uh oh!

bedevere-bot commented Mar 18, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

serhiy-storchaka commented Dec 25, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.