GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-46032: Check types in singledispatch's register() at declaration time (GH-30050) by serhiy-storchaka · Pull Request #30254 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 25, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The registry() method of functools.singledispatch() functions checks now
the first argument or the first parameter annotation and raises a TypeError if it is
not supported. Previously unsupported "types" were ignored (e.g. typing.List[int])
or caused an error at calling time (e.g. list[int]).

(cherry picked from commit 078abb6)

https://bugs.python.org/issue46032

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-46032: Check types in singledispatch's register() at declaration …
57d774e 
…time (pythonGH-30050)

The registry() method of functools.singledispatch() functions checks now
the first argument or the first parameter annotation and raises a TypeError if it is
not supported. Previously unsupported "types" were ignored (e.g. typing.List[int])
or caused an error at calling time (e.g. list[int]).

(cherry picked from commit 078abb6)
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.9 label Dec 25, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger as a code owner December 25, 2021 13:28
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 25, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 25, 2021
AlexWaygood
AlexWaygood approved these changes Dec 25, 2021
View reviewed changes
@serhiy-storchaka serhiy-storchaka changed the title bpo-46032: Check types in singledispatch's register() at declaration time (GH-30050) [3.10] bpo-46032: Check types in singledispatch's register() at declaration time (GH-30050) Dec 25, 2021
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Dec 25, 2021
@bedevere-bot bedevere-bot mentioned this pull request Dec 25, 2021
bpo-46032: Check types in singledispatch's register() at declaration time #30050
Merged
@serhiy-storchaka
serhiy-storchaka merged commit 03c7449 into python:3.10 Dec 25, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 25, 2021
@miss-islington

miss-islington commented Dec 25, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the backport-078abb6-3.10 branch December 25, 2021 14:12
@bedevere-bot

bedevere-bot commented Dec 25, 2021

Copy link
Copy Markdown

GH-30255 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 25, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2021
@serhiy-storchaka @miss-islington
[3.10] bpo-46032: Check types in singledispatch's register() at decla…
30125cd 
…ration time (pythonGH-30050) (pythonGH-30254)

The registry() method of functools.singledispatch() functions checks now
the first argument or the first parameter annotation and raises a TypeError if it is
not supported. Previously unsupported "types" were ignored (e.g. typing.List[int])
or caused an error at calling time (e.g. list[int]).

(cherry picked from commit 078abb6)
(cherry picked from commit 03c7449)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Dec 26, 2021
@miss-islington @serhiy-storchaka
[3.9] bpo-46032: Check types in singledispatch's register() at declar…
25a12aa 
…ation time (GH-30050) (GH-30254) (GH-30255)

The registry() method of functools.singledispatch() functions checks now
the first argument or the first parameter annotation and raises a TypeError if it is
not supported. Previously unsupported "types" were ignored (e.g. typing.List[int])
or caused an error at calling time (e.g. list[int]).

(cherry picked from commit 078abb6)
(cherry picked from commit 03c7449)

Co-authored-by: Serhiy Storchaka <[email protected]>
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 10, 2022
functools' singledispatch does not support GenericAlias #90190
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @AlexWaygood @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.