GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-23952: Document cgi module's maxlen variable by hugovk · Pull Request #30338 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Jan 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Using the text suggested in https://bugs.python.org/issue23952.

I think this documentation-only change can skip a NEWS file.

https://bugs.python.org/issue23952

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
bpo-23952: Document cgi module's maxlen variable
a1978d6
@hugovk
hugovk requested a review from ethanfurman as a code owner January 2, 2022 20:12
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 2, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 2, 2022
rhettinger
rhettinger requested changes Jan 2, 2022
View reviewed changes

@rhettinger rhettinger left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. Please also update the main docs at Docs/library/cgi.rst.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot removed the awaiting review label Jan 2, 2022
@bedevere-bot

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting changes label Jan 2, 2022
@rhettinger rhettinger added skip news docs Documentation in the Doc dir labels Jan 2, 2022
@hugovk
bpo-23952: Document cgi module's maxlen variable
c224527
@hugovk

hugovk commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

This is a good start. Please also update the main docs at Docs/library/cgi.rst.

Updated!

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jan 2, 2022
@bedevere-bot

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot
bedevere-bot requested a review from rhettinger January 2, 2022 20:39
ethanfurman
ethanfurman requested changes Jan 2, 2022
View reviewed changes
Comment thread Lib/cgi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting changes and removed awaiting change review labels Jan 2, 2022
@bedevere-bot

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
bpo-23952: maxlen is a global variable
90442ca
@hugovk

hugovk commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jan 2, 2022
@bedevere-bot

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger, @ethanfurman: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot
bedevere-bot requested a review from ethanfurman January 2, 2022 21:16
ethanfurman
ethanfurman approved these changes Jan 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jan 2, 2022
@github-actions

github-actions Bot commented Feb 2, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 2, 2022
ethanfurman
ethanfurman approved these changes Feb 2, 2022
View reviewed changes
@ethanfurman ethanfurman added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed stale Stale PR or inactive for long period of time. labels Feb 5, 2022
@bedevere-bot

bedevere-bot commented Feb 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ethanfurman for commit 90442ca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2022
@hugovk

hugovk commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

test_issue16464 (test.test_urllib2.MiscTests) ... ERROR failed with urllib.error.HTTPError: HTTP Error 404: Not Found.

Details
test_issue16464 (test.test_urllib2.MiscTests) ... ERROR
======================================================================
ERROR: test_issue16464 (test.test_urllib2.MiscTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/test/support/socket_helper.py", line 245, in transient_internet
    yield
    ^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/test/test_urllib2.py", line 1803, in test_issue16464
    opener.open(request, "1234567890".encode("us-ascii"))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 525, in open
    response = meth(req, response)
               ^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 634, in http_response
    response = self.parent.error(
               ^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 563, in error
    return self._call_chain(*args)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 496, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
urllib.error.HTTPError: HTTP Error 404: Not Found

https://buildbot.python.org/all/#/builders/217/builds/431/steps/5/logs/stdio

Likely unrelated to this docs change, so rescheduling.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2022
@bedevere-bot

bedevere-bot commented Feb 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 90442ca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2022
@hugovk

hugovk commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Same thing. The test_issue16464 failure is unrelated; https://bugs.python.org/issue46648 / #31146 / #31148.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman
ethanfurman merged commit 6c4e44e into python:main Feb 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 6, 2022
@hugovk
hugovk deleted the 23952-cgi-document-maxlen branch February 6, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @bedevere-bot @rhettinger @ethanfurman @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.