GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46648: test_urllib2.test_issue16464() uses httpbin.org by vstinner · Pull Request #31146 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".

https://bugs.python.org/issue46648

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-46648: test_urllib2.test_issue16464() uses httpbin.org
11b42e1 
The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 5, 2022
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Feb 5, 2022
@vstinner

vstinner commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

cc @corona10 @ambv
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran suggested changes Feb 5, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 5, 2022
@bedevere-bot

bedevere-bot commented Feb 5, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Feb 5, 2022
@tiran tiran mentioned this pull request Feb 5, 2022
bpo-40280: Address more test failures on Emscripten (GH-31050) #31050
Merged
@GBeauregard GBeauregard mentioned this pull request Feb 5, 2022
bpo-46642: explicitly disallow typing.TypeVar instance subclassing #31148
Merged
@hugovk hugovk mentioned this pull request Feb 5, 2022
bpo-23952: Document cgi module's maxlen variable #30338
Merged
@vstinner

vstinner commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

test_urllib2 is failing on all buildbots right now because example.com is no longer reliable. Do you have a better suggestion?

I'm not aware of any pythontest.net URL supporting POST.

Either we switch to any other URL or the test should be skipped. Most buildbots are failing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orsenthil

orsenthil commented Feb 6, 2022

Copy link
Copy Markdown
Member

Hi @vstinner, I am with @tiran here. If possible m we should use pythontest . I think, it supports simple post.

If blocked by external resources, we can skip the test. BTW test_urllib2net is supposed to depend on external sources. The test_urllib2 should have mocks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Feb 6, 2022
@vstinner
vstinner deleted the urllib2_issue16464 branch February 6, 2022 14:09
@vstinner

vstinner commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

I merged my PR #31161 instead (skip the test).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @bedevere-bot @orsenthil @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.