GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. by methane · Pull Request #30409 · python/cpython

Conversation

@methane

@methane methane commented Jan 5, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46236

Automerge-Triggered-By: GH:pablogsal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple.
7fbe986
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 5, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 5, 2022
@methane methane added needs backport to 3.10 type-bug An unexpected behavior, bug, or error labels Jan 5, 2022
@methane
fixup
a41b64e
sweeneyde
sweeneyde reviewed Jan 5, 2022
View reviewed changes
Comment thread Objects/funcobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@methane
Add assertion
1a75c41
kumaraditya303
kumaraditya303 reviewed Jan 5, 2022
View reviewed changes
Comment thread Objects/funcobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Jan 5, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/C API/2022-01-05-10-16-16.bpo-46236.pcmVQw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Misc/NEWS.d/next/C API/2022-01-05-10-16-16.bpo-46236.pcmVQw.rst
9bc2a72
pablogsal
pablogsal approved these changes Jan 5, 2022
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the quick fix, @methane!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 5, 2022
@pablogsal pablogsal added the 🤖 automerge label Jan 5, 2022
@miss-islington

miss-islington commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

@methane: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 46e4c25 into python:main Jan 5, 2022
@miss-islington

miss-islington commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2022
@methane @miss-islington
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. (pythonGH-…
4a3b386 
…30409)

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 46e4c25)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jan 5, 2022
@bedevere-bot

bedevere-bot commented Jan 5, 2022

Copy link
Copy Markdown

GH-30420 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jan 5, 2022
@miss-islington @methane
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. (GH-30409)
da8be15 
Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 46e4c25)

Co-authored-by: Inada Naoki <[email protected]>
@larryhastings larryhastings mentioned this pull request Oct 5, 2022
PyFunction_GetAnnotations is probably causing ref leaks #97943
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneyde sweeneyde sweeneyde left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@methane @miss-islington @bedevere-bot @pablogsal @sweeneyde @kumaraditya303 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.