GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Remove empty footnote section by nedbat · Pull Request #30451 · python/cpython

Conversation

nedbat commented Jan 7, 2022

Copy link

Copy Markdown

Member

There are no footnotes on this page, so no need for a "Footnotes" header.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove empty footnote section

8ab1dbd

the-knights-who-say-ni added the CLA signed label

Jan 7, 2022

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Jan 7, 2022

AlexWaygood added skip issue skip news labels

Jan 7, 2022

kumaraditya303 approved these changes

Jan 11, 2022

View reviewed changes

kumaraditya303 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting core review and removed awaiting review labels

Jan 11, 2022

github-actions Bot commented Feb 11, 2022

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Feb 11, 2022

nedbat commented Feb 11, 2022

Copy link

Copy Markdown

Member Author

@encukou Can we get this merged?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

Feb 12, 2022

kumaraditya303 commented Mar 3, 2022

Copy link

Copy Markdown

Contributor

@JelleZijlstra This can be merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra self-assigned this

Mar 3, 2022

JelleZijlstra added the needs backport to 3.10 label

Mar 8, 2022

JelleZijlstra commented Mar 8, 2022

Copy link

Copy Markdown

Member

Going to merge this into 3.10 and main only because in the 3.9 docs there is a footnote. (cc @gvanrossum)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra merged commit 13331a1 into python:main

Mar 8, 2022

miss-islington commented Mar 8, 2022

Copy link

Copy Markdown

Contributor

Thanks @nedbat for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed awaiting core review needs backport to 3.10 labels

Mar 8, 2022

bedevere-bot commented Mar 8, 2022

Copy link

Copy Markdown

GH-31745 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 8, 2022


          importlib.metadata: Remove empty footnote section (pythonGH-30451)

1d7c4de

(cherry picked from commit 13331a1)

Co-authored-by: Ned Batchelder <[email protected]>

miss-islington added a commit that referenced this pull request

Mar 8, 2022


          importlib.metadata: Remove empty footnote section (GH-30451)

f6cdf5b

(cherry picked from commit 13331a1)

Co-authored-by: Ned Batchelder <[email protected]>

This change gets overwritten when syncing the changes from importlib_metadata, such as in #31854. I can port the change to importlib_metadata so that doesn't happen, but please be cognizant of making editorial changes to importlib.metadata, importlib.resources, and the docs for importlib.metadata, as they're kept in sync with the backports. If you have any suggestions on how to guide contributors to limit these sorts of edits, please let me know.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco commented Mar 13, 2022

Copy link

Copy Markdown

Member

Ported as python/importlib_metadata@467dba53dd48.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nedbat deleted the nedbat/remove-empty-footnotes branch

March 26, 2022 11:41

Reviewers

kumaraditya303

kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.