GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-46364: Use sockets only for stdin of asyncio on AIX by xopham · Pull Request #30596 · python/cpython

bpo-46364: Use sockets only for stdin of asyncio on AIX #30596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

gvanrossum merged 2 commits into python:main from xopham:fix-issue-46364

Oct 13, 2022

Uh oh!

There was an error while loading. Please reload this page.

Merged

bpo-46364: Use sockets only for stdin of asyncio on AIX #30596

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

2 commits

Select commit Hold shift + click to select a range

a0a38c1

bpo-46364: only use socket for stdin on AIX

File filter

Filter by extension .py (2) .rst (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

7 changes: 3 additions & 4 deletions 7 Lib/asyncio/unix_events.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -788,12 +788,11 @@ class _UnixSubprocessTransport(base_subprocess.BaseSubprocessTransport):

		def _start(self, args, shell, stdin, stdout, stderr, bufsize, **kwargs):
		stdin_w = None
		if stdin == subprocess.PIPE:
		# Use a socket pair for stdin, since not all platforms
		if stdin == subprocess.PIPE and sys.platform.startswith('aix'):
		# Use a socket pair for stdin on AIX, since it does not
		# support selecting read events on the write end of a
		# socket (which we use in order to detect closing of the
		# other end). Notably this is needed on AIX, and works
		# just fine on other platforms.
		# other end).
		stdin, stdin_w = socket.socketpair()
		try:
		self._proc = subprocess.Popen(
Expand Down

20 changes: 20 additions & 0 deletions 20 Lib/test/test_asyncio/test_subprocess.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -401,6 +401,26 @@ async def empty_error():
		self.assertEqual(output, None)
		self.assertEqual(exitcode, 0)

		@unittest.skipIf(sys.platform != 'linux', "Don't have /dev/stdin")
		def test_devstdin_input(self):

		async def devstdin_input(message):
		code = 'file = open("/dev/stdin"); data = file.read(); print(len(data))'
		proc = await asyncio.create_subprocess_exec(
		sys.executable, '-c', code,
		stdin=asyncio.subprocess.PIPE,
		stdout=asyncio.subprocess.PIPE,
		stderr=asyncio.subprocess.PIPE,
		close_fds=False,
		)
		stdout, stderr = await proc.communicate(message)
		exitcode = await proc.wait()
		return (stdout, exitcode)

		output, exitcode = self.loop.run_until_complete(devstdin_input(b'abc'))
		self.assertEqual(output.rstrip(), b'3')
		self.assertEqual(exitcode, 0)

		def test_cancel_process_wait(self):
		# Issue #23140: cancel Process.wait()

Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2022-01-14-10-49-20.bpo-46364.SzhlU9.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Restrict use of sockets instead of pipes for stdin of subprocesses created by :mod:`asyncio` to AIX platform only.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.