GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-28961: Address my comments from earlier code review by berkerpeksag · Pull Request #306 · python/cpython

Conversation

@berkerpeksag

@berkerpeksag berkerpeksag commented Feb 26, 2017

Copy link
Copy Markdown
Member

(cherry picked from commit dea1536)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@berkerpeksag
bpo-28961: Address my comments from earlier code review
7c99a88 
(cherry picked from commit dea1536)
@berkerpeksag berkerpeksag added the cherry-pick for 3.6 label Feb 26, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 26, 2017
Mariatta
Mariatta approved these changes Feb 26, 2017
View reviewed changes
@berkerpeksag
berkerpeksag merged commit fae59e1 into python:3.6 Feb 26, 2017
@berkerpeksag
berkerpeksag deleted the 28961-backport-3.6 branch February 26, 2017 13:05
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump pytest from 5.3.2 to 5.3.3 (#306)
5627150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@berkerpeksag @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.