GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46402: Promote SQLite URI tricks in `sqlite3` docs by erlend-aasland · Pull Request #30660 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 18, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46402

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner January 18, 2022 10:25
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 18, 2022
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 18, 2022
@erlend-aasland erlend-aasland added skip news needs backport to 3.9 and removed awaiting review labels Jan 18, 2022
Erlend E. Aasland
bpo-46402: Promote sqlite3 URI tricks in docs
f04bf42
@erlend-aasland
erlend-aasland force-pushed the sqlite-doc-uri-tricks branch from 71812f7 to f04bf42 Compare January 18, 2022 11:36
Erlend E. Aasland
fetchall() returns (potentially) multiple rows
461cbf3
nedbat
nedbat reviewed Jan 18, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nedbat

nedbat commented Jan 18, 2022

Copy link
Copy Markdown
Member

This is great, thanks! I don't know if my vote counts for anything, but I approve. :)
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland @nedbat
Address review: Simplify URI explanation
ae5877e 
Co-authored-by: Ned Batchelder <[email protected]>
@erlend-aasland

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @nedbat :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Reformat to max 80 chars pr. line
de7867e
@erlend-aasland
erlend-aasland requested a review from ericvsmith January 18, 2022 12:09
@ericvsmith

ericvsmith commented Jan 18, 2022

Copy link
Copy Markdown
Member

I think this looks great.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericvsmith
ericvsmith approved these changes Jan 18, 2022
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Jan 18, 2022
@erlend-aasland

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

Thanks, Eric!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

BTW, would you mind merging it? I don't have the commit bit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith

ericvsmith commented Jan 18, 2022

Copy link
Copy Markdown
Member

Will do.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith
ericvsmith merged commit bdf2ab1 into python:main Jan 18, 2022
@miss-islington

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 18, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-doc-uri-tricks branch January 18, 2022 12:37
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jan 18, 2022
@bedevere-bot

bedevere-bot commented Jan 18, 2022

Copy link
Copy Markdown

GH-30661 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 18, 2022

Copy link
Copy Markdown

GH-30662 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jan 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
Erlend Egeberg Aasland @miss-islington
bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-30660)
7b2d484 
Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <[email protected]>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
Erlend Egeberg Aasland @miss-islington
bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-30660)
4c14a65 
Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <[email protected]>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

cc. @JulienPalard: I only need to update suspicious for the backports, right? (file: triggers the suspicious checks in 3.10 and 3.9).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

FYI: I'm closing the auto-backports and doing them myself in order to get the suspicious fixes into those.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericvsmith pushed a commit that referenced this pull request Jan 18, 2022
Erlend Egeberg Aasland
[3.10] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (GH-30660) (
01e6cbe 
GH-30671)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (GH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <[email protected]>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

* Update suspicious rules
ericvsmith pushed a commit that referenced this pull request Jan 18, 2022
Erlend Egeberg Aasland
[3.9] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (GH-30660) (…
0ae2257 
…#30672)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (GH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <[email protected]>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

* Update suspicious rules
@nedbat nedbat mentioned this pull request May 16, 2022
Enhance sqlite3 to avoid implicit creation? #90560
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Erlend Egeberg Aasland @hello-adam
[3.9] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-…
7d252fb 
…30660) (python#30672)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (pythonGH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <[email protected]>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

* Update suspicious rules
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedbat nedbat nedbat left review comments
@ericvsmith ericvsmith ericvsmith approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @nedbat @ericvsmith @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.