GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46430: Intern strings in deep-frozen modules by kumaraditya303 · Pull Request #30683 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jan 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46430

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 19, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 19, 2022
gvanrossum
gvanrossum reviewed Jan 19, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this isn't going to be enough, alas. :-(

I've tried to drop a few hints in the review. :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/scripts/deepfreeze.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/scripts/deepfreeze.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/scripts/deepfreeze.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Jan 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'll revisit this once statically allocated strings land by @ericsnowcurrently See #30928
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 marked this pull request as draft January 31, 2022 07:54
@gvanrossum

gvanrossum commented Jan 31, 2022

Copy link
Copy Markdown
Member

I'll revisit this once statically allocated strings land by @ericsnowcurrently

To be clear you're referencing faster-cpython/ideas#230 and #30928 here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 and others added 2 commits February 6, 2022 14:29
@kumaraditya303
intern strings
5ead58b
@blurb-it @kumaraditya303
📜🤖 Added by blurb_it.
b2d3eb2
@kumaraditya303
kumaraditya303 force-pushed the intern branch from 198a965 to b2d3eb2 Compare February 6, 2022 09:00
kumaraditya303 added 4 commits February 6, 2022 09:03
@kumaraditya303
rework
ed8f718
@kumaraditya303
rework
a5d9fab
@kumaraditya303
fix warning
f6d207a
@kumaraditya303
space
08dc8e5
gvanrossum
gvanrossum approved these changes Feb 7, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just think we shouldn't ignore errors.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/codeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 7, 2022
@kumaraditya303
kumaraditya303 marked this pull request as ready for review February 7, 2022 13:22
@kumaraditya303
kumaraditya303 requested a review from markshannon as a code owner February 7, 2022 13:22
@kumaraditya303 kumaraditya303 mentioned this pull request Feb 7, 2022
Look into string sharing for deep-frozen code faster-cpython/ideas#218
Closed
methane
methane approved these changes Feb 9, 2022
View reviewed changes
gvanrossum
gvanrossum approved these changes Feb 9, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fair enough.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
gvanrossum merged commit c0a5ebe into python:main Feb 9, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 9, 2022
@kumaraditya303
kumaraditya303 deleted the intern branch February 9, 2022 19:04
@vstinner

vstinner commented Feb 23, 2022

Copy link
Copy Markdown
Member

The change introduced a regression: https://bugs.python.org/issue46430#msg413822
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Christopher-Chianelli Christopher-Chianelli mentioned this pull request Apr 16, 2023
Populate the initial per-interpreter interned_strings dict with runtime-global singleton strings #103571
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kumaraditya303 @gvanrossum @vstinner @methane @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.